reused dead NewMemstore() function #8680
Conversation
mixer/pkg/adapter/configError.go
Outdated
| @@ -75,7 +75,7 @@ func (e *ConfigErrors) Append(field string, err error) *ConfigErrors { | |||
|
|
|||
| // Error returns a string representation of the configuration error. | |||
| func (e ConfigError) Error() string { | |||
| return fmt.Sprintf("%s: %s", e.Field, e.Underlying) | |||
| return fmt.Sprintf("%s: %s", e.Field, e.Underlying.Error()) | |||
There was a problem hiding this comment.
This is unnecessary , because exist of func (e ConfigError) String() string {
stewart-yu
force-pushed
the
stewart-istio-codeclean03
branch
from
8031092
to
641b83a
Compare
stewart-yu
changed the title
|
/ok-to-test |
|
/test istio-unit-tests |
|
@stewart-yu: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, ozevren The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
should not reconstruct a new
Memstoreobjective, andNewMemstore()function is dead function,