define types.BoolValue var in pkg/proto/types.go

[hzxuzhonghu]

fix // TODO: extract this into istio.io/pkg/proto/{bool.go or types.go or values.go}

[codecov]

Codecov Report

Merging #9216 into master will decrease coverage by 1%.
The diff coverage is 84%.

@@           Coverage Diff           @@
##           master   #9216    +/-   ##
=======================================
- Coverage      70%     70%   -<1%     
=======================================
  Files         431     431            
  Lines       40488   40352   -136     
=======================================
- Hits        28262   28097   -165     
- Misses      10853   10887    +34     
+ Partials     1373    1368     -5

Impacted Files	Coverage Δ
pilot/pkg/networking/plugin/health/health.go	53% <100%> (-1%)	⬇️
pilot/pkg/networking/core/v1alpha3/route/route.go	72% <100%> (ø)	⬆️
mixer/pkg/runtime/routing/builder.go	58% <100%> (ø)	⬆️
mixer/pkg/runtime/config/ephemeral.go	96% <100%> (ø)	⬆️
...ilot/pkg/networking/plugin/authn/authentication.go	79% <100%> (ø)	⬇️
pilot/pkg/networking/core/v1alpha3/httproute.go	86% <100%> (ø)	⬆️
pilot/pkg/networking/core/v1alpha3/gateway.go	47% <72%> (ø)	⬇️
pilot/pkg/networking/core/v1alpha3/listener.go	76% <78%> (+1%)	⬆️
istioctl/pkg/install/verify.go	21% <0%> (-4%)	⬇️
...olarwinds/internal/papertrail/papertrail_logger.go	81% <0%> (-3%)	⬇️
... and 21 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba67713...4e59444. Read the comment docs.

[hzxuzhonghu]

/test istio-unit-tests

[supereagle]

If move types.BoolValue into pkg/proto/types.go, then this imported package is not needed any more.

Please fix https://github.com/istio/istio/pull/9216/files#diff-9eec7bb8f46726e51ab373e7b8e11ca7L428

[hzxuzhonghu]

done

[supereagle]

LGTM

[hzxuzhonghu]

rebased， ptal

[rshriram]

/lgtm

[istio-testing]

New changes are detected. LGTM label has been removed.

[hzxuzhonghu]

/test e2e-mixer-no_auth

[hzxuzhonghu]

/retest

[hzxuzhonghu]

/test e2e-bookInfoTests-envoyv2-v1alpha3

[istio-testing]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• mixer/test/client/OWNERS [rshriram]
• pilot/pkg/networking/OWNERS [hzxuzhonghu,rshriram]
• pkg/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hzxuzhonghu]

What's wrong with circle ci?

[istio-testing]

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
prow/e2e-simpleTests-cni.sh	4e59444	link	/test e2e-simpleTests-cni
prow/istio-integ-k8s-tests.sh	4e59444	link	/test istio-integ-k8s-tests
prow/e2e-mixer-no_auth-mcp.sh	4e59444	link	/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.