This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ayj
commented
Feb 17, 2017
•
edited
Loading
edited
- Initial integration with codecov.io and Jenkins. See https://codecov.io/gh/istio/manager for reports)
- Race detection is temporarily disabled because istio.io/manage has some data races. Will file follow-up bugs for those.
- Codecov is triggered on presubmit. This means the published codecov.io includes reports for the istio.io/manager/master as well as all of the pending PR. This is not a huge deal (yet) since we can differentiate reports on codecov.io's website based on commit summary.
Jenkins job manager/presubmit passed |
Jenkins job manager/presubmit passed |
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=========================================
Coverage ? 31.47%
=========================================
Files ? 19
Lines ? 1757
Branches ? 0
=========================================
Hits ? 553
Misses ? 1153
Partials ? 51 Continue to review full report at Codecov.
|
Jenkins job manager/presubmit passed |
Jenkins job manager/presubmit passed |
kyessenov
approved these changes
Feb 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
70fdbe6
to
43a8a10
Compare
Jenkins job manager/presubmit passed |
1 similar comment
Jenkins job manager/presubmit passed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.