Skip to content
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.

Support HTTPS #312

Merged
merged 3 commits into from
Mar 13, 2017
Merged

Support HTTPS #312

merged 3 commits into from
Mar 13, 2017

Conversation

kyessenov
Copy link
Contributor

Treat HTTPS as opaque TCP traffic.

Build fixes:

  • organize init scripts
  • document go1.8 as a requirement
  • start errors with lower case
  • fix istioctl test dependency

@istio-testing
Copy link
Contributor

Jenkins job manager/presubmit passed

@codecov
Copy link

codecov bot commented Mar 13, 2017

Codecov Report

Merging #312 into master will not change coverage.
The diff coverage is 42.85%.

@@           Coverage Diff           @@
##           master     #312   +/-   ##
=======================================
  Coverage   63.62%   63.62%           
=======================================
  Files          23       23           
  Lines        2367     2367           
=======================================
  Hits         1506     1506           
  Misses        751      751           
  Partials      110      110
Impacted Files Coverage Δ
model/service.go 100% <ø> (ø)
proxy/envoy/config.go 91% <100%> (ø)
cmd/istioctl/main.go 53.89% <20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65eb55a...2f5ed34. Read the comment docs.

@istio-testing
Copy link
Contributor

Jenkins job manager/presubmit passed

@rshriram
Copy link
Member

Why do we need to go down this path? I thought the auth service was going to handle inter-service https. We need to do ingress level https for sure and I think @ijsnellf is taking a crack at it, with kube secrets based option as a first start

@kyessenov
Copy link
Contributor Author

It's two separate problems:

  1. app doesn't trust Istio with https, we just route it as TCP
  2. app chooses to use Istio auth (e.g. ingress), we implement Istio auth design

@kyessenov kyessenov merged commit 431ba27 into istio:master Mar 13, 2017
@kyessenov kyessenov deleted the https branch March 13, 2017 20:36
@kyessenov kyessenov mentioned this pull request Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants