[wip] Proxy cfg validation & route generation #68
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
platform/kube/client.go
Outdated
| @@ -360,7 +361,7 @@ func modelToKube(km model.KindMap, obj *model.Config) (*Config, error) { | |||
| return out, nil | |||
| } | |||
|
|
|||
| func protoToMap(msg proto.Message) (map[string]interface{}, error) { | |||
| func protoToMap(msg proxycf.ProxyConfig) (map[string]interface{}, error) { | |||
There was a problem hiding this comment.
don't specialize this method - it's meant to be used for all proto messages (there is a descriptor field in each generated Go source)
platform/kube/client.go
Outdated
| // if err != nil { | ||
| // return nil, err | ||
| // } | ||
| // } |
There was a problem hiding this comment.
leave this code as is, you can use a dummy proto for status (like the one in mock_config). I'm pretty sure we will need this later but it doesn't hurt now.
ijsnellf
force-pushed
the
proxy_cfg_validation
branch
3 times, most recently
from
a61064b
to
dc2e5e9
Compare
rshriram
changed the title
rshriram
force-pushed
the
proxy_cfg_validation
branch
from
c667f34
to
d26d170
Compare
This change is