Introduce routing rule as TPR #82
Conversation
| import "google/protobuf/wrappers.proto"; | ||
|
|
||
| package istio.proxy.v1alpha.config; | ||
| option go_package = "config"; |
There was a problem hiding this comment.
I didn't know that this option was possible! Can we change the name to routingcfg ?
| // itself from the evolution of dependent services. | ||
|
|
||
| // Proxy level global configurations go here | ||
| message ProxyConfig { |
There was a problem hiding this comment.
And this gets renamed to RoutingConfig?
There was a problem hiding this comment.
Unless we decide to add more stuff into proxy config, such as envoy userid, etc.
| var errs error | ||
| if !kindRegexp.MatchString(k.Kind) { | ||
| if !IsDNS1123Label(k.Kind) { |
There was a problem hiding this comment.
Doesn't this mean we need atleast two parts in the kind name ? route-rule.istio.io? If so the constants above need to be updated.
|
|
||
| rule := &proxyconfig.RouteRule{ | ||
| RouteRule: &proxyconfig.RouteRule_Http{ | ||
| Http: &proxyconfig.HttpRouteRule{ |
There was a problem hiding this comment.
Please add dst_service here. We may need to do immediate validation in tpr code to see if the user provided service is valid or invalid
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
I signed it! |
Re-work the glue for TPR since discovering an issue with multiple TPRs.
Changed the storage scheme so that the name encodes the kind (e.g. proxy rule a is called proxy-rule-a in kubernetes).
Included proto definitions and generated code for proxy-related config for faster iteration.
Will add a CLI to accommodate put/get operations for TPRs with validation in a follow-up PR.