Skip to content
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.

Collect coverage information from unit and integration tests #104

Closed
kyessenov opened this issue Feb 8, 2017 · 5 comments
Closed

Collect coverage information from unit and integration tests #104

kyessenov opened this issue Feb 8, 2017 · 5 comments

Comments

@kyessenov
Copy link
Contributor

No description provided.

@kyessenov
Copy link
Contributor Author

If anyone is interested in extracting coverage from k8s pods, feel free to tackle this!
We're at a pretty low coverage right now, and we need to improve the situation.

@ayj
Copy link
Contributor

ayj commented Feb 17, 2017

AFAICT, golang test coverage is only gathered from go unit tests, i.e. "go test -cover". There doesn't seem to be a way to extract coverage stats from non-tests. If we wanted to improve test coverage we'd need to beef up existing tests (e.g. with k8s/envoy mocks) and/or write additional unit tests that run on pods that can verify the glue logic that isn't covered by mocks, etc.

@ayj ayj self-assigned this Feb 17, 2017
@ayj
Copy link
Contributor

ayj commented Feb 17, 2017

Starting to work on this. First step is getting basic unit test coverage published to github.com/istio/manager via jenkins. We can then follow-up with incremental PR to increase coverage.

@kyessenov
Copy link
Contributor Author

Thanks! Take a look at mixer set-up with code coverage website integration. The problem with bazel tests is that it's really hard to do e2e stuff like iptables and envoy call-out. So we might need to do extensive mocking to get unit tests working for config generation.

@ayj
Copy link
Contributor

ayj commented Feb 18, 2017

Codecov integration is in with #171 and
#174.

I'll start looking at increasing the code coverage % next week.

@ayj ayj closed this as completed Feb 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants