Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kickoff sds api #1932

Merged
merged 83 commits into from
Aug 21, 2018
Merged

Kickoff sds api #1932

merged 83 commits into from
Aug 21, 2018

Conversation

JimmyCYJ
Copy link
Member 

NONE

kyessenov and others added 30 commits July 3, 2018 12:56
@kyessenov
update envoy
0646709 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@hklai
Merge pull request istio#1838 from kyessenov/extra_field
5b05f36 
update envoy
@vadimeisenbergibm
update Envoy's SHA to latest
0bfb526 
to include the SNI inspecting method, for using SNI in telemetry and
policies

Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
@vadimeisenbergibm
Merge branch 'release-1.0' into update_envoy_sha_3b05bffcbaedaf6d112b…
eb2afdd 
…a38ad58121ba5aa5af51

Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
@hklai
Merge pull request istio#1839 from vadimeisenbergibm/update_envoy_sha…
09a0919 
…_3b05bffcbaedaf6d112ba38ad58121ba5aa5af51

update Envoy's SHA to latest, to implement SNI telemetry reports and policy checks
@kyessenov
implement destination.principal
f004f04 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov
missing test
0bbb1a0 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov
review
ff0bddd 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@vadimeisenbergibm
add AttributeName::kConnectionRequestedServerName
93e6641
@vadimeisenbergibm
fix format
777b38f
@vadimeisenbergibm
add GetRequestedServerName() to TCP CheckData
cb543c1
@vadimeisenbergibm
add building attribute ConnectionRequestedServerName
2ead919
@vadimeisenbergibm
test building attribute ConnectionRequestedServerName
b45b25d
@vadimeisenbergibm
add GetRequestedServerName() to tcp mixer filter
83dd6a0
@vadimeisenbergibm
fix compilation errors
0091e10
@vadimeisenbergibm
use explicit conversion from absl::string_view to std::string
79fa89f
@vadimeisenbergibm
check that the requested server name is not emtpy in attributes builder
336a0f0
@vadimeisenbergibm
fixed a compilation error
1389681
@vadimeisenbergibm
add GetRequestedServerName to http mixer filters (check_data)
a129dbf
@vadimeisenbergibm
add GetRequestedServerName to http MockCheckData
b1967a2
@vadimeisenbergibm
specify the class of a method
b874c59
@vadimeisenbergibm
add setting connection.requested_server_name to the http attributes
43e4bea
@vadimeisenbergibm
qualify Return by testing::
715ce48
@vadimeisenbergibm
use connection_ as a pointer
c3ab69c
@vadimeisenbergibm
add explicit conversion from absl::string_view to std::string
76fe1d8
@vadimeisenbergibm
add missing mock call
3da5327
@hklai
Merge pull request istio#1843 from vadimeisenbergibm/add_connection_r…
1464e5e 
…equested_server_name_attribute

Add connection requested server name attribute to TCP read filter
@hklai
Revert "Add connection requested server name attribute to TCP read fi…
4ea0ea0 
…lter"
@hklai
Merge pull request istio#1844 from istio/revert-1843-add_connection_r…
1a62f8b 
…equested_server_name_attribute

Revert "Add connection requested server name attribute to TCP read filter"
@vadimeisenbergibm
update the API SHA (istio/api#575)
4a02b92
bianpengyuan and others added 15 commits August 9, 2018 18:32
@bianpengyuan @istio-testing
Add two new attributes: request.url_path and request.queries (istio#1837
5d09f41 
)

* Add two new attributes:  request.url_path and request.queries

* Update api in repositories.bzl
@quanjielin @istio-testing
update ENVOY_SHA (istio#1904)
ec327ad 
* update ENVOY_SHA

* change WORKSPACE file
@kyessenov @istio-testing
skip empty sni (istio#1909)
7fde77a 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@yangminzhu @istio-testing
add rbac filter to istio http integration test. (istio#1907)
b1f4e7e 
* add rbac filter to istio http integration test.

* rename issueer for rbac test.
@PiotrSikora @rshriram
Fix macOS build on CircleCI. (istio#1916)
5d42471 
Apparently, automake is now installed automatically,
which broke the brew install step.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora @rshriram
Install clang-format in the build image used by CircleCI. (istio#1917)
b49589a 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora @rshriram
Provide source version information in the binary. (istio#1915)
c63d841 
Before:

    $ bazel-bin/src/envoy/envoy --version

    bazel-bin/src/envoy/envoy  version: 0/1.8.0-dev//DEBUG

After:

    $ bazel-bin/src/envoy/envoy --version

    bazel-bin/src/envoy/envoy  version: f315a32fc7c6f727fc9645cc1ca27d4160c1d0e0/1.8.0-dev/Clean/DEBUG

Fixes #1803.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@trabetti @rshriram
fixed broken links to dev guide and contribution guide (istio#1913)
585abec
@PiotrSikora @istio-testing
Update clang to 6.0 and use it for release binaries. (istio#1914)
4ced9e7 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora @istio-testing
Update Envoy SHA to latest with LcTrie optimizations. (istio#1918)
c5282b6 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@quanjielin @istio-testing
add debug logs for collecting rbac attributes (istio#1922)
1fc6253
@kyessenov @istio-testing
populate source user without authn (istio#1926)
4865583 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@yangminzhu @istio-testing
update API sha. (istio#1927)
4ee7e8e
@qiwzhang @istio-testing
Add a check cache test for string map sub keys (istio#1931)
a32a587 
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
@JimmyCYJ
update Envoy SHA
9d18908
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmycyj

If they are not already assigned, you can assign the PR to them by writing /assign @jimmycyj in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 21, 2018
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Aug 21, 2018
@JimmyCYJ JimmyCYJ added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Aug 21, 2018
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 21, 2018
@JimmyCYJ JimmyCYJ merged commit 99222fa into istio:sds_api Aug 21, 2018
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiwzhang qiwzhang Awaiting requested review from qiwzhang

@rshriram rshriram Awaiting requested review from rshriram

Assignees
No one assigned
Labels
cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.
Projects
None yet
Milestone
No milestone