-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use istio envoy release-1.8 instead of envoy-wasm #3055
Conversation
envoy-wasm has been merged to envoy envoyproxy/envoy#12546
😊 Welcome @joaovitor! This is either your first contribution to the Istio proxy repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @joaovitor. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @joaovitor istio/proxy master currently references istio/envoy release-1.8 branch, because we are about to cut istio release-1.8 and it needs to map to envoy 1.16 (which is what istio/envoy release-1.8 is currently at). Could you update the bazel file to be the same as that repo please? thanks! |
as requested by @bianpengyuan #3055 (comment)
/ok-to-test |
@bianpengyuan just updated it. |
What this PR does / why we need it:
Updates the envoy version used in the istio proxy to use official envoy instead of envoy-wasm.
envoy-wasm has been merged to envoy envoyproxy/envoy#12546
Special notes for your reviewer:
I just updated with
curl -sSL https://raw.githubusercontent.com/envoyproxy/envoy/master/.bazelrc > envoy.bazelrc