Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use istio envoy release-1.8 instead of envoy-wasm #3055

Merged
merged 2 commits into from
Oct 16, 2020
Merged

use istio envoy release-1.8 instead of envoy-wasm #3055

merged 2 commits into from
Oct 16, 2020

Conversation

joaovitor
Copy link
Contributor

What this PR does / why we need it:

Updates the envoy version used in the istio proxy to use official envoy instead of envoy-wasm.
envoy-wasm has been merged to envoy envoyproxy/envoy#12546

Special notes for your reviewer:

I just updated with curl -sSL https://raw.githubusercontent.com/envoyproxy/envoy/master/.bazelrc > envoy.bazelrc

@joaovitor joaovitor requested a review from a team October 16, 2020 21:14
@istio-policy-bot
Copy link

😊 Welcome @joaovitor! This is either your first contribution to the Istio proxy repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 16, 2020
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Oct 16, 2020
@istio-testing
Copy link
Collaborator

Hi @joaovitor. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bianpengyuan
Copy link
Contributor

Hi @joaovitor istio/proxy master currently references istio/envoy release-1.8 branch, because we are about to cut istio release-1.8 and it needs to map to envoy 1.16 (which is what istio/envoy release-1.8 is currently at). Could you update the bazel file to be the same as that repo please? thanks!

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2020
@bianpengyuan
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Oct 16, 2020
@joaovitor
Copy link
Contributor Author

@bianpengyuan just updated it.

@joaovitor joaovitor changed the title use envoy master instead of envoy-wasm use istio envoy release-1.8 instead of envoy-wasm Oct 16, 2020
@istio-testing istio-testing merged commit 0db11f3 into istio:master Oct 16, 2020
@joaovitor joaovitor deleted the use-envoy-master branch October 19, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants