envoy: http connection pool for metadata upstream extension #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/M
|
Cc @kyessenov |
|
LGTM |
|
/retest |
|
Could anyone review this? This is basically the same as |
|
Any test? |
|
No, see the reviewer notes; considering there aren't any unit tests for |
lizan
approved these changes
May 5, 2021
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Next step for istio/istio#31444
Special notes for your reviewer: Keeping PR size small for easier reviews. There weren't associated unit tests for
HttpConnPool; this would be tested in future extension-level tests