Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build envoy with debug #5399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build envoy with debug #5399

wants to merge 1 commit into from

Conversation

nirvanagit
Copy link

No description provided.

@nirvanagit nirvanagit requested a review from a team as a code owner March 11, 2024 16:11
@istio-policy-bot
Copy link

😊 Welcome @nirvanagit! This is either your first contribution to the Istio proxy repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2024
@istio-testing
Copy link
Collaborator

Hi @nirvanagit. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -64,6 +64,7 @@ common --experimental_allow_tags_propagation
build:linux --copt=-fdebug-types-section
build:linux --copt=-fPIC
build:linux --copt=-Wno-deprecated-declarations
build:linux --copt=-fno-limit-debug-info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is currently empty. Can you add to the PR description of 1) why this option needs to be added; 2) pros and cons of adding this option?

@kyessenov
Copy link
Contributor

Also, this will be overwritten by Envoy sync anyways. We have debug builds of Envoy but they are O(Gb) sized. Why do you want this on all builds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
5 participants