New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build envoy with debug #5399
base: master
Are you sure you want to change the base?
Build envoy with debug #5399
Conversation
😊 Welcome @nirvanagit! This is either your first contribution to the Istio proxy repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @nirvanagit. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -64,6 +64,7 @@ common --experimental_allow_tags_propagation | |||
build:linux --copt=-fdebug-types-section | |||
build:linux --copt=-fPIC | |||
build:linux --copt=-Wno-deprecated-declarations | |||
build:linux --copt=-fno-limit-debug-info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description is currently empty. Can you add to the PR description of 1) why this option needs to be added; 2) pros and cons of adding this option?
Also, this will be overwritten by Envoy sync anyways. We have debug builds of Envoy but they are O(Gb) sized. Why do you want this on all builds? |
No description provided.