Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use best practice from k8s for code coverage and linters #233

Closed
sebastienvas opened this issue Jun 8, 2017 · 3 comments
Closed

Use best practice from k8s for code coverage and linters #233

sebastienvas opened this issue Jun 8, 2017 · 3 comments

Comments

@sebastienvas
Copy link
Contributor

According to @fejta, Kubernetes is using a fork of gazelle and have code coverage and linters done differently. @ixdy might be able to help us.

@ixdy
Copy link
Contributor

ixdy commented Jun 14, 2017

we're currently using a completely separate tool (https://github.com/mikedanese/gazel) which shares no code with gazelle but accomplishes much of the same things, along with some kubernetes-specific functionality, notably https://github.com/mikedanese/gazel/blob/master/gazel/generator.go and https://github.com/mikedanese/gazel/blob/master/gazel/sourcerer.go.

we're planning to switch to gazelle and use gazel (or a successor) only for the non-Go functionality. it sounds like that might be what you're interested in.

@ixdy
Copy link
Contributor

ixdy commented Jun 14, 2017

@sebastienvas sebastienvas added this to the Istio 0.3 milestone Aug 17, 2017
@BenTheElder
Copy link

Note that prow has had a plugin for /lint which covers golint at least, I think we have more work to do on these fronts though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants