Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boskos dependency to sigs.k8s.io/boskos #2691

Merged
merged 3 commits into from
Jun 9, 2020

Conversation

ixdy
Copy link
Contributor

@ixdy ixdy commented Jun 2, 2020

This additionally updates the k8s.io/test-infra dependency.

Boskos has moved into kubernetes-sigs/boskos, so I'm preemptively updating the dep here so that future updates are painless. There shouldn't be any notable boskos functionality changes.

One code-breaking change was introduced by the test-infra bump (kubernetes/test-infra#17016). I believe I've maintained the existing behavior, but I don't know if it'd make sense to instead switch to DecorateAllJobs (the new feature).

This additionally updates the k8s.io/test-infra dependency.
@ixdy ixdy requested a review from a team as a code owner June 2, 2020 22:00
@istio-policy-bot
Copy link

😊 Welcome @ixdy! This is either your first contribution to the Istio test-infra repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 2, 2020
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test labels Jun 2, 2020
@istio-testing
Copy link
Collaborator

Hi @ixdy. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn
Copy link
Contributor

ericvn commented Jun 3, 2020

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 3, 2020
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2020
@ixdy
Copy link
Contributor Author

ixdy commented Jun 3, 2020

I'm probably going to need some help to handle the license issues here.

github.com/garyburd/redigo is licensed under an Apache license, but it's missing the appendix, which is probably confusing the linter:

@@ -172,30 +173,3 @@
       defend, and hold each Contributor harmless for any liability
       incurred by, or claims asserted against, such Contributor by reason
       of your accepting any such warranty or additional liability.
-
-   END OF TERMS AND CONDITIONS
-
-   APPENDIX: How to apply the Apache License to your work.
-
-      To apply the Apache License to your work, attach the following
-      boilerplate notice, with the fields enclosed by brackets "{}"
-      replaced with your own identifying information. (Don't include
-      the brackets!)  The text should be enclosed in the appropriate
-      comment syntax for the file format. We also recommend that a
-      file or class name and description of purpose be included on the
-      same "printed page" as the copyright notice for easier
-      identification within third-party archives.
-
-   Copyright {yyyy} {name of copyright owner}
-
-   Licensed under the Apache License, Version 2.0 (the "License");
-   you may not use this file except in compliance with the License.
-   You may obtain a copy of the License at
-
-       http://www.apache.org/licenses/LICENSE-2.0
-
-   Unless required by applicable law or agreed to in writing, software
-   distributed under the License is distributed on an "AS IS" BASIS,
-   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-   See the License for the specific language governing permissions and
-   limitations under the License.

github.com/yvasiyarov/go-metrics is basically a fork of github.com/rcrowley/go-metrics and has the same license; the latter is already whitelisted, so we probably need to do the same for the former.

@ixdy
Copy link
Contributor Author

ixdy commented Jun 3, 2020

opened istio/common-files#259 to address the license issues.

@ixdy
Copy link
Contributor Author

ixdy commented Jun 3, 2020

/retest

@ixdy
Copy link
Contributor Author

ixdy commented Jun 3, 2020

Tests are all passing now. Updating the license lint configuration was surprisingly painless.

Copy link
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istio-testing istio-testing merged commit f8534a5 into istio:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants