Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic Prow Job to Update Istio Dependency SHA #400

Merged
merged 5 commits into from
Aug 22, 2017
Merged

Conversation

chxchx
Copy link
Contributor

@chxchx chxchx commented Aug 22, 2017

An example PR created is istio/istio#588

Notice that it reads SHA from stable branch of each dependency. For the entire dependency update scheme to be automated, it also needs the fast-forward jobs that move stable up-to-date with master, which will be done in another PR shortly after.

Release note:

NONE

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 22, 2017
@chxchx
Copy link
Contributor Author

chxchx commented Aug 22, 2017

/assign @sebastienvas
/assign @yutongz
PTAL

@sebastienvas
Copy link
Contributor

/lgtm
/approve

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebastienvas

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue

@istio-merge-robot istio-merge-robot merged commit 6ed49d4 into master Aug 22, 2017
@istio-testing
Copy link
Collaborator

@chxchx: I updated Prow config for you!.

In response to this:

An example PR created is istio/istio#588

Notice that it reads SHA from stable branch of each dependency. For the entire dependency update scheme to be automated, it also needs the fast-forward jobs that move stable up-to-date with master, which will be done in another PR shortly after.

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants