Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more XDS operational metrics #1104

Closed
howardjohn opened this issue May 31, 2024 · 4 comments · Fixed by #1205
Closed

Add more XDS operational metrics #1104

howardjohn opened this issue May 31, 2024 · 4 comments · Fixed by #1205
Assignees

Comments

@howardjohn
Copy link
Member

  • Number of messages
  • Total message size (counter) by type
@MorrisLaw
Copy link
Contributor

Where are these currently defined (the XDS operational metrics)?

context: if I wanted to add this I'm not sure where to start.

@howardjohn
Copy link
Member Author

src/xds/metrics.rs is what we have currently

@MorrisLaw
Copy link
Contributor

Is message an existing type somewhere? Or, does it need to be created (like how ConnectionTermination is in metrics.rs) and should it have any particular fields?

@howardjohn
Copy link
Member Author

I think we would just report based on

size = response.resources.len(),
.

Note size on that line is actually count. I think we also want the byte size. Which would be raw.resource.unwrap().value.len() on each responses.resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants