Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement stats object that can store stats from each request #12

Closed
howardjohn opened this issue Oct 19, 2022 · 9 comments
Closed

Implement stats object that can store stats from each request #12

howardjohn opened this issue Oct 19, 2022 · 9 comments
Assignees
Labels
area/debuggability Area: Debuggability (logs, utils, admin endpoints, etc) P0 size/TBD

Comments

@howardjohn
Copy link
Member

No description provided.

@jewertow
Copy link
Member

jewertow commented Oct 20, 2022

As we've talked, I will do some research on this topic and will try to prototype something.

@stevenctl stevenctl added area/debuggability Area: Debuggability (logs, utils, admin endpoints, etc) P0 labels Nov 9, 2022
@stevenctl stevenctl added this to the M1: Productionalization milestone Nov 9, 2022
@stevenctl
Copy link
Contributor

This may need a bit of investigation to nail down requirements. At a minimum:

Stats per identity (or pair of identities) for things such as:

Total connections

Failed connections

Active Connections

Many other things

See Envoy’s upstream cluster stats for some examples of what we want to track.

@SkyfireFrancisZ
Copy link

Jacek is prototyping the type of metrics to be collected.

Best to submit a PR with instrumentation and minimal metrics to kickstart the discussion.

@linsun
Copy link
Member

linsun commented Dec 1, 2022

The task requires more than stats obj, @jewertow would like to unassign him for now.

@stevenctl
Copy link
Contributor

#244

@stevenctl
Copy link
Contributor

Should we close this or continue to track work for inbound stats here?

@howardjohn
Copy link
Member Author

I think we can use this to track future stats

@SkyfireFrancisZ
Copy link

will have PR out later today

@howardjohn
Copy link
Member Author

Basic stats are implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/debuggability Area: Debuggability (logs, utils, admin endpoints, etc) P0 size/TBD
Projects
Status: Done
Development

No branches or pull requests

5 participants