Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune TLS settings #21

Open
howardjohn opened this issue Oct 19, 2022 · 11 comments
Open

Tune TLS settings #21

howardjohn opened this issue Oct 19, 2022 · 11 comments

Comments

@howardjohn
Copy link
Member

Should use a strict cipher set and TLS 1.3 only

@stevenctl stevenctl added area/performance Area: Performance P0 labels Nov 9, 2022
@stevenctl stevenctl added this to the M1: Performance milestone Nov 9, 2022
@stevenctl
Copy link
Contributor

Restrict to 1.3

Use a strict cipher set

@EItanya
Copy link
Contributor

EItanya commented Nov 14, 2022

Should this be configurable or static?

@hzxuzhonghu
Copy link
Member

in some older kernel , tls 1.3 can not be supported, why not like envoy make min version tls 1.2

@howardjohn
Copy link
Member Author

Why is the kernel involved? TLS is done is user space...?

@hzxuzhonghu
Copy link
Member

To be accurate it should be the lib that an os installed

@howardjohn
Copy link
Member Author

We statically link the SSL library (like Envoy and Go)

@hzxuzhonghu
Copy link
Member

IC, that make sense

@ymesika
Copy link
Member

ymesika commented Nov 17, 2022

Is this task for tuning the HBONE connection TLS settings?
I'm asking because currently min/max version is already 1.3: https://github.com/istio/ztunnel/blob/master/src/tls/boring.rs#L172

@howardjohn
Copy link
Member Author

Yes, its more than just version. The SSL libraries are probably the most unfriendly APIs ever designed. For every option, there are 3 ways to set it, and there are 100s of options. We need to make sure we pick the ones that are most secure and performant.

@SkyfireFrancisZ
Copy link

@howardjohn has this been implemented already? If not, is this required for zTunnel reaching Alpha in OSS?

@howardjohn
Copy link
Member Author

IMO it should be a blocker for someone to give it a pass over to make sure we are using secure settings. Shouldn't be too much effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

6 participants