-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gen 2 Support #349
Comments
I was able to fix the theme problem myself. I just added images for pokemon 152-650 for good measure and app uses them just fine. All that remains is filter updates though so I can filter commons again without it filtering ALL gen 2 |
I tried making a theme, but my icons keep blinking 😨 Edit: Edit 2: |
TheNewDarkOne: replace in global.h: with: and filter option is working again. |
I mean building from source sure, but the source is currently behind app store version. :\ |
@TheNewDarkOne Can you share with me your theme plz ? |
Honestly I took the updated sprites from rocketmap (https://stuff.notfurprofit.org/static02.zip) and used those for personal use. |
@istornz This is important! Please hurry up i need this lovely notifications for new mons :D |
@Alderon86 I'm sick so I will do that ASAP. |
@istornz Hi, you ill update the ipa / source for 2gen pokemons?. Thank you for ur work :) |
@jorgitoh IPA & AppStore version 👍 |
@istornz hi is it possible to add the moveset support at the same time when clicking on the 'mon plz? |
One step at a time, i'd rather him just get the media/filters updated first, worry about features later. |
Anyone can test the new version with latest theme (don't have server to test) : https://github.com/istornz/iPokeGo/wiki/Centralization-of-all-downloadable-theme#official-rocketmap-theme If it's ok I will publish a version on the AppStore 👍 |
Does that version support themes, though? Can't find it in the settings. |
Can you upload an ipa to test it out? Sry I don't have a mac so i can't compile |
Far as I know the themes stuff was never merged into this branch. a few features appeared only in app store version which is why I stopped using source version. |
Okay, but to answer your question, @istornz, everything works (ish). AppStore version (screenshot) works perfectly with the RocketMap sprites (albeit without filtering) GitHub version (screenshot) works with gen 2, because I added notifications for some gen 2 commons and it took me to the location in the screenshot with no Pokèmon (because no gen 2 sprites in GitHub version). See both screenshots, same area, proving Github version works with gen 2 now, just without any sprites. So, App Store version (with themes) just needs the following, as mentioned by @thedruid: |
I created a gen 2 support PR, if anyone wants it before an AppStore version is made / accepted by Apple. It contains new gen 1 and 2 sprites, and reduced number of Pokémon from 255 to 251. Before and after screenshot. (Pidgey and Spinarak hidden by filter, to name a few) |
Add the theme functionality in order to remove copyrighted images from project.
Hi sorry guys I have forgotten to include the theme support 👎 @johnforeland Thanks for your PR, but I need to remove all copyrighted image from this repo 🤐 I will submit the AppStore version today ! |
Version 2.5.1 submitted to the AppStore 👍 |
i did a clean build and tested all day, was good with rocketmap theme. filters and all were perfect |
@TheNewDarkOne Okay thanks for your reply, I close this issue 👍 |
It kinda works if using text/themeless but can't use any filters or it stops working. hide common? hides common AND all gen 2, etc. so no filter, text theme to do gen 2
what needs though is images for gen 2 in themes, and filters to add support for handling up to 250.
The text was updated successfully, but these errors were encountered: