fix: Fix permissions on SDK generation #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorban-isp
reviewed
Jun 13, 2024
| @@ -57,15 +57,14 @@ jobs: | |||
| - name: Re-generate isp | |||
| run: ./run.sh | |||
|
|
|||
| - name: Re-generate isp-slates | |||
| - name: Re-generate isp-slate | |||
There was a problem hiding this comment.
nit: it's called the Slates API I wonder if it makes more sense to change the folder to isp-slates rather than change the step to isp-slate?
There was a problem hiding this comment.
Will do in a separate PR shortly!
aorban-isp
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating the SDK is failing, due to permissions errors on generated files. Seems to be peter-evans/create-pull-request#783.