Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starts spinning when mouse is kept hovering over button after click #96

Closed
diesl opened this issue Apr 26, 2018 · 8 comments
Closed

Starts spinning when mouse is kept hovering over button after click #96

diesl opened this issue Apr 26, 2018 · 8 comments

Comments

@diesl
Copy link
Contributor

diesl commented Apr 26, 2018

I upgraded the touchspin component from 3.x to the latest 4.x release these days and noticed some different behaviour:

3.x:
When clicking the + or - buttons, they will just increase or decrease the value by the stepsize. When I keep holding the mouse button down, it will start spinning. So far, so good.

4.x:
When clicking the + or - buttons, they start spinning when I keep the mouse hovering over the button until I leave the button.

Is this intended behaviour? Personally, I prefer the 3.x way and would at least ask to make it configurable, so that I can disable it.

@istvan-ujjmeszaros
Copy link
Owner

Strange, I don't remember for any changes that could affect it, I think it should stop in v3 too when leaving the button..
I think there were some cases when the browser didn't fire the mouseup event and the spinner didn't stop at all, but I will look into it.

@bogdandynamic
Copy link

I also have the same problem with bootstrap 4.

@istvan-ujjmeszaros
Copy link
Owner

Are you guys sure that it was behaving different in the previous versions?
I have just checked back to v2.7.0 from four years ago and it seems to work the same (I don't say that this behavior is good, just want to make sure that we are on the same track).

@bogdandynamic
Copy link

Personally, I am using the widget for the first time and don't see this as a feature but rather like an unwanted behaviour. The rest of the functionality is excelent and I must congratulate you for your work, but please add a property so that this behaviour can be disabled or enabled.
Thank you.

@istvan-ujjmeszaros
Copy link
Owner

I think I have misunderstood the issue. I see now that the number keeps spinning after releasing the mouse button. It is definitely a bug.

@bogdandynamic
Copy link

Your fix works only on the left button. On the right one still spins.

@istvan-ujjmeszaros
Copy link
Owner

Dang. Thanks for the feedback. Updating in a couple minutes.

@diesl
Copy link
Contributor Author

diesl commented Apr 26, 2018

Just came back online and there is already a fixed version. Thank you very much for your quick response!
I can confirm that the bug is fixed in version 4.2.5 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants