Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: hide tags and page.summary #40

Closed
1 of 3 tasks
woojiq opened this issue Aug 17, 2023 · 3 comments · Fixed by #41
Closed
1 of 3 tasks

Feature request: hide tags and page.summary #40

woojiq opened this issue Aug 17, 2023 · 3 comments · Fixed by #41

Comments

@woojiq
Copy link
Contributor

woojiq commented Aug 17, 2023

Hi, first of all thanks for creating this theme, it looks great. Here are a few features I would like to see in this theme.

  • Option to justify blog text. Iiuc this needs something like this Way to justify posts rhazdon/hugo-theme-hello-friend-ng#20 (comment). EDIT: I don't need it anymore. I realized that I can @import "../theme/serene/sass/main.scss" so after updating serene I won't need to copy new css anymore.
  • Option to hide tags even if they are present. I like to tag but not show. I can just comment them out in the markup, but if I have 20 posts and suddenly realize I want to show the tags, it's going to take a long time.
  • Option to not include page.summary in a blog post. This will be useful if you want to add a summary for rss andwant to remove this text from the beginning of a post. In the future page.summary can be used under post name on the blog page.

EDIT: I've done it locally, waiting to hear from you if you want it in serene.

@woojiq woojiq changed the title Feature request: justify text, hide tags, hide page.summary. Feature request: hide tags and page.summary Aug 18, 2023
@isunjn
Copy link
Owner

isunjn commented Aug 18, 2023

@woojiq
Copy link
Contributor Author

woojiq commented Aug 18, 2023

For 'justify', I agree to this post: https://ruitina.com/dont-justify-text-on-websites-and-apps/ and prefer not to add an option for that.

text-align: justify + hyphens: auto; looks not bad. I saw it on https://matklad.github.io/. Anyway, yea, it can be easily changed on a client side.

I'm not following the idea of removing page.summary, could you explain it a bit more.

I want to write descriptions for articles, but description will not be just the beginning of the article, but a short description of the entire article (summary). Therefore, it is not appropriate to show it at the beginning. At the same time, the description is useful for the rss feed and later it would be nice to show summary under post title on the blog page (like here). For example look at the card generetaed by openring
image
and the article itself. As you can see, description is not included in the blog post. Hope you understand what I mean.

@isunjn
Copy link
Owner

isunjn commented Aug 19, 2023

Now I get it, this involves updating docs, I'm working on it.

For display_tags, seems trivial, open a pr if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants