Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] asd #19

Closed
wants to merge 4 commits into from
Closed

[skip ci] asd #19

wants to merge 4 commits into from

Conversation

isuruf
Copy link
Owner

@isuruf isuruf commented Sep 1, 2016

No description provided.

@isuruf
Copy link
Owner Author

isuruf commented Sep 1, 2016

needs more work

@isuruf
Copy link
Owner Author

isuruf commented Sep 1, 2016

sign off

@isuruf
Copy link
Owner Author

isuruf commented Sep 1, 2016

needs more work

@isuruf
Copy link
Owner Author

isuruf commented Sep 1, 2016

sign off

@isuruf
Copy link
Owner Author

isuruf commented Sep 1, 2016

pr needs more work

@asmeurer
Copy link

asmeurer commented Sep 1, 2016

Are there events for labels (and is it possible to remove the label once the status is set)?

@asmeurer
Copy link

asmeurer commented Sep 1, 2016

sign off

@asmeurer
Copy link

asmeurer commented Sep 1, 2016

What is the status when you push a commit before any comments are made?

@isuruf
Copy link
Owner Author

isuruf commented Sep 1, 2016

No status. It can either be a success, failure, pending or no status

@isuruf
Copy link
Owner Author

isuruf commented Sep 1, 2016

Yes, there are events for labeling, unlabeling, etc. https://developer.github.com/webhooks/#events
It's also possible to remove the label after the status is set.

@isuruf
Copy link
Owner Author

isuruf commented Sep 1, 2016

@isuruf
Copy link
Owner Author

isuruf commented Sep 3, 2016

@asmeurer, how about a simple system like this ?

  • When somebody comments needs more work, PR; authors' turn label is added
  • When a person adds a commit, PR: reviewer's turn label is added

Status is not changed at all

@isuruf isuruf closed this Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants