Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After installation of 4.12.1.0, creating a new iswix solution (either version) errors out with VS 2017 15.8.4/15.8.5 #9

Closed
frizzr opened this issue Sep 20, 2018 · 5 comments
Assignees

Comments

@frizzr
Copy link

frizzr commented Sep 20, 2018

The error is below. It creates the folders for the solution but no files are created underneath them:

image

This issue is not there with the previous version 4.11.18042.1...just FYI.

It sounds like a missing dependency. You did remove this dependency here, but you may still need it: 67b3037#diff-a0b02469e831dbdafed297e01e323e03

I also use Resharper and VsVim within Visual Studio. If you can't reproduce, I can provide all my plugins.

@Helmi-helmutson
Copy link

+1 same error here

1 similar comment
@rexunderlinehxiao
Copy link

+1 same error here

@chrpai
Copy link
Contributor

chrpai commented Nov 17, 2018

I apologize as I never noticed an alert for this issue. I assume you've gone back to a previous version of IsWiX and are operational. I will look at this issue this weekend. Will you be available to test a fix? Do you know what the missing dependency is? GlobalParams? That component was marked as permenant so perhaps if you install a previous version then install the latest version it will work. I haven't begun my root cause investigation yet.

@chrpai chrpai self-assigned this Nov 17, 2018
@chrpai
Copy link
Contributor

chrpai commented Nov 17, 2018

Root cause complete. GlobalParams.dll was a runtime dependency of both the old and the new addin but was only included in the old addin feature for the installer. I've made the code change and will release the new build very soon.

chrpai added a commit that referenced this issue Nov 17, 2018
Fix regression caused by removal of "old"  addin
@chrpai
Copy link
Contributor

chrpai commented Nov 17, 2018

Release 4.12.2.0 published. Please retest and confirm issue resolution and I'll close the issue.

@chrpai chrpai closed this as completed Nov 17, 2018
@chrpai chrpai reopened this Nov 17, 2018
@chrpai chrpai closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants