Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install.sh: automatically set default external endpoint and interface #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update install.sh: automatically set default external endpoint and interface #7

wants to merge 1 commit into from

Conversation

ceyes
Copy link

@ceyes ceyes commented Mar 1, 2020 •
edited

This patch will make the install.sh to automatically get the instance's external IP address and default network interface, then set as fallback value so user can skip them. Tested pass on my ec2 with and without these parameters.

shrinidhi111
shrinidhi111 approved these changes Apr 1, 2020
View reviewed changes
Copy link

@shrinidhi111 shrinidhi111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just working on adding these two additional features to have an option to automatically default interface and IP.

Tested this and works as expected. I recommend these changes as they are simply addition but saves a lot of debugging for first timers.

@jadolg
Copy link

jadolg commented Jun 29, 2020

@alexey-chernyavskiy would you please merge this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrinidhi111 shrinidhi111 shrinidhi111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ceyes @jadolg @shrinidhi111