Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property mismatch in class CronJobConfiguration.java of digiwf-s3-integration-starter #1706

Closed
boal opened this issue May 22, 2024 · 7 comments
Assignees

Comments

@boal
Copy link
Contributor

boal commented May 22, 2024

Describe the bug

The digiwf-s3-integration-starter has an property mismatch in class CronJobConfiguration.java. To enable the cronjobs the propeties under de.muenchen.oss.digiwf.s3.cronjob.cleanup are expected. The properties under ``io.muenchendigital.digiwf.s3.cronjob.cleanup` are only used to define the cronjob intervall.

image

To Reproduce
Steps to reproduce the behavior:

  1. Define properties of io.muenchendigital.digiwf.s3.cronjob.cleanup.expired-files and io.muenchendigital.digiwf.s3.cronjob.cleanup.unused-files
  2. Do not define properties of de.muenchen.oss.digiwf.s3.cronjob.cleanup.expired-files and de.muenchen.oss.digiwf.s3.cronjob.cleanup.unused-files
  3. The cronjobs are not configurated because the ConditionalOnProperty-Annotation is not triggered.

Expected behavior

A definition of the properties under ``io.muenchendigital.digiwf.s3.cronjob.cleanup` should be sufficient .

Screenshots
n/a

Copy link
Contributor

👋 Thanks for reporting! The maintainers have been notified and will get back to you.

@boal boal changed the title Propertymismatch in Class CronJobConfiguration.java of digiwf-s3-integration-starter Property mismatch in class CronJobConfiguration.java of digiwf-s3-integration-starter May 22, 2024
@darenegade
Copy link
Member

@darenegade
Copy link
Member

Es gibt noch einige Stellen, wo noch die alte Domain verwendet wird:

https://github.com/search?q=repo%3Ait-at-m%2Fdigiwf-core+io.muenchendigital&type=code&p=1

@darenegade
Copy link
Member

@boal Wir werden das bei uns einplanen und umsetzen

@boal
Copy link
Contributor Author

boal commented May 23, 2024

Beim client der s3 integration gibt es einen mismatch bei der Propertybenennung.

image

versus

image

@markostreich
Copy link
Contributor

markostreich commented Jun 24, 2024

Die S3 Properties werden umbenannt, sodass sie ohne package-Namen mit digiwf beginnen.

@markostreich markostreich assigned lehju and unassigned markostreich Jun 26, 2024
lehju added a commit that referenced this issue Jul 1, 2024
lehju added a commit that referenced this issue Jul 1, 2024
@markostreich markostreich mentioned this issue Jul 1, 2024
2 tasks
lehju added a commit that referenced this issue Jul 1, 2024
@lehju
Copy link
Contributor

lehju commented Jul 1, 2024

lehju added a commit that referenced this issue Jul 3, 2024
lehju added a commit that referenced this issue Jul 3, 2024
…ation-mismatch' of https://github.com/it-at-m/digiwf-core into bugfix/#1706-cronjobconfiguration-property-of-s3-integration-mismatch
lehju added a commit that referenced this issue Jul 4, 2024
…#1812)

* #1706: rename de.muenchen.oss.digiwf.s3 / io.muenchendigital.digiwf.s3 to digiwf.s3

* #1706: rename de.muenchen.oss.digiwf.s3 to digiwf.s3 in S3IntegrationClientAutoConfiguration

* Update digiwf-integrations/digiwf-s3-integration/digiwf-s3-integration-service/src/main/resources/application.yml

Co-authored-by: markostreich <markostreich@users.noreply.github.com>

* #1706: review feedback
@markostreich markostreich mentioned this issue Jul 5, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants