Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1202 upgrade @muenchen/vjsf version #1233

Merged
merged 5 commits into from
Jan 18, 2024
Merged

#1202 upgrade @muenchen/vjsf version #1233

merged 5 commits into from
Jan 18, 2024

Conversation

markostreich
Copy link
Contributor

Description

upgrade @muenchen/vjsf version

Reference

Issues: closes #1202

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@markostreich markostreich self-assigned this Jan 17, 2024
@markostreich markostreich linked an issue Jan 17, 2024 that may be closed by this pull request
Englische Labels bei Objekt-Listen #1202
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a96e59) 38.55% compared to head (774d595) 38.55%.
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev    #1233   +/-   ##
=========================================
  Coverage     38.55%   38.55%           
  Complexity     1311     1311           
=========================================
  Files           599      599           
  Lines          8677     8677           
  Branches        424      424           
=========================================
  Hits           3345     3345           
  Misses         5196     5196           
  Partials        136      136
Flag Coverage Δ
unittests 38.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir
Copy link
Member

simonhir commented Jan 18, 2024 •
edited
Loading

Irgendwas scheint da nicht zu passen, theoretisch sollten sich nur die package-lock.json-Dateien verändern bei denen auch die package.json angepasst wurde.
Hab das mal überprüft und ist bei mir lokal und in der letzten Änderung ca7fb28 die vjsf gehoben hat auch so.

@markostreich
Copy link
Contributor Author

Scheint ein Bug beim Aufruf von 'npm install' zu sein. npm/cli#4263

Ich setze die "resolve"s zurück.

@markostreich
Copy link
Contributor Author

@simonhir
Die package-lock.json sollten nun repariert sein.

@markostreich
Copy link
Contributor Author

Ok, doch noch ein Fehler...

@markostreich
Copy link
Contributor Author

@simonhir

Schaue bitte nochmals drüber.

@markostreich markostreich merged commit f656cb1 into dev Jan 18, 2024
7 checks passed
@markostreich markostreich deleted the 1202-englische-labels-bei-objekt-listen branch January 18, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhir simonhir simonhir approved these changes

Assignees

@markostreich markostreich

Labels
digiwf-apps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Englische Labels bei Objekt-Listen
2 participants
@markostreich @simonhir