Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#923 add screenreader support to multi user input #1730

Merged
merged 10 commits into from
Jun 4, 2024

Conversation

lehju
Copy link
Contributor

@lehju lehju commented May 27, 2024

Description

Add screenreader support to multi user input and user input

Reference

Issues: #923

Screenshots (If UI changed)

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.73%. Comparing base (6f7c1ae) to head (a38a339).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1730   +/-   ##
=========================================
  Coverage     44.73%   44.73%           
  Complexity     1706     1706           
=========================================
  Files           653      653           
  Lines          9629     9629           
  Branches        477      477           
=========================================
  Hits           4308     4308           
  Misses         5139     5139           
  Partials        182      182           
Flag Coverage Δ
unittests 44.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir simonhir self-requested a review May 28, 2024 08:03
Copy link
Member

@simonhir simonhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Der eine Punkt ist mir noch aufgefallen sonst siehst gut aus

@lehju lehju merged commit c0deac9 into dev Jun 4, 2024
18 of 19 checks passed
@lehju lehju deleted the feature/#923-add-screenreader-support-to-multi-user-input branch June 4, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants