Merge pull request #32 from it-goats/chore/eslint-config-update

[NOJIRA] Update ESLint config
it-goats · Apr 30, 2022 · 87ace71 · 87ace71
2 parents 0e0aa21 + f52ed31
commit 87ace71
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 8 deletions.
diff --git a/cabra/.eslintrc.json b/cabra/.eslintrc.json
@@ -17,7 +17,15 @@
   },
   "plugins": ["@typescript-eslint", "prettier"],
   "rules": {
+    "camelcase": "error",
+    "eqeqeq": "error",
     "no-console": "error",
+    "prefer-const": "error",
+    "no-var": "error",
+    "react/function-component-definition": [
+      "error",
+      { "namedComponents": "function-declaration" }
+    ],
     "react/react-in-jsx-scope": "off",
     "sort-imports": "error",
     "@typescript-eslint/no-inferrable-types": "off",

diff --git a/cabra/src/pages/components/CardField.tsx b/cabra/src/pages/components/CardField.tsx
@@ -25,11 +25,13 @@ interface Props {
   align?: Align;
 }
 
-const CardField = ({ className, children, title, span, align }: Props) => (
-  <Field className={className} $span={span} $align={align}>
-    {title && <Title>{title}</Title>}
-    {children}
-  </Field>
-);
+function CardField({ className, children, title, span, align }: Props) {
+  return (
+    <Field className={className} $span={span} $align={align}>
+      {title && <Title>{title}</Title>}
+      {children}
+    </Field>
+  );
+}
 
 export default CardField;
diff --git a/cabra/src/pages/components/RelatedTaskList.tsx b/cabra/src/pages/components/RelatedTaskList.tsx
@@ -30,7 +30,7 @@ export default function RelatedTasksList({
 
   const subtasks = data.data.slice().reverse();
 
-  if (subtasks.length == 0) {
+  if (subtasks.length === 0) {
     return <div>{"<No tasks>"}</div>;
   }
 

diff --git a/cabra/src/pages/components/TasksList.tsx b/cabra/src/pages/components/TasksList.tsx
@@ -14,7 +14,7 @@ export default function TasksList() {
 
   const tasks = data.data;
 
-  const hasNoTasks = !tasks || tasks.length == 0;
+  const hasNoTasks = !tasks || tasks.length === 0;
   return (
     <Container>
       {hasNoTasks ? (