[ITG-79] Setup CI #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgargula
reviewed
Apr 8, 2022
.github/workflows/bode_ci.yaml
Outdated
Comment on lines
3
to
7
| on: | ||
| pull_request: | ||
| paths: | ||
| - "bode/**" | ||
| branches: [develop, master] |
There was a problem hiding this comment.
Wdyt of adding:
push:
branches: [develop, master]
Since our repo is public, we don't have limitations on the CI
See Github pricing: https://github.com/pricing
There was a problem hiding this comment.
Well, why not 💸 💸 💸
I think we can go even further and do
on:
pull_request:
paths:
- "cabra/**"
push:
paths:
- "cabra/**"
.github/workflows/cabra_ci.yaml
Outdated
Comment on lines
3
to
7
| on: | ||
| pull_request: | ||
| paths: | ||
| - "cabra/**" | ||
| branches: [develop, master] |
There was a problem hiding this comment.
I would add it here as well.
push:
branches: [develop, master]
tgargula
reviewed
Apr 8, 2022
Comment on lines
+7
to
+9
| push: | ||
| paths: | ||
| - "bode/**" |
There was a problem hiding this comment.
I think every push means also running after pushing from local -- it may be doubled and unnecessary. Wdyt?
There was a problem hiding this comment.
Yeah, this way you can see if CI is passing without creating a PR, the feedback loop is a bit shorter. I think we can leave it like that, merge, observe if we have redundant workflow runs and then adjust accordingly if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI setup for
bodeandcabra.Resources
https://kulawska.atlassian.net/browse/ITG-79