[ITG-44] Implementacja endpointu GET do pobrania zadań będących w relacji z danym zadaniem #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-sonz
requested changes
Apr 22, 2022
Comment on lines
36
to
45
| @blueprint.route("/<task_id>") | ||
| class TasksInRelationWith(MethodView): | ||
| @blueprint.response(200, TasksRelationSchema(many=True)) | ||
| def get(self, task_id): | ||
| try: | ||
| return TaskRelation.query.filter(TaskRelation.first_task_id == task_id).all() or abort(404) | ||
| except DataError: | ||
| abort(404) | ||
| except NoResultFound: | ||
| abort(404, message="Item not found.") |
There was a problem hiding this comment.
Getting only the relations record is not really useful. When using this API route you'd want to have some data about the related tasks in the response, like title, due_date, etc. The response scheme should more or less look like this:
class RelatedTaskSchema(BaseSchema):
id = fields.UUID(dump_only=True) # relation id
type = fields.String() # relation type
related_task = fields.nested(TaskSchema) # the task object that is related that is in relation with the given taskAlso, you don't need to catch these errors when returning lists. A response with an empty list of related tasks is not exceptional and should return 200 response code.
gregori0o
requested changes
Apr 22, 2022
added 3 commits
April 27, 2022 15:02
…d tasks). Made task deletion operation recursive (according to subtasks).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.