Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITG-95] Update styles of task list and task form according to the design #24

Merged
merged 10 commits into from
Apr 27, 2022

Conversation

john-sonz
Copy link
Collaborator

Updated styling of task creation and edition form, task list, and the done checkbox.


Resources

ITG-95

@john-sonz john-sonz self-assigned this Apr 25, 2022
@john-sonz john-sonz changed the title [ITG-95] Update styles of task list and task form according to the desing [ITG-95] Update styles of task list and task form according to the design Apr 25, 2022
Copy link
Contributor

@koszar91 koszar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor visual issues:

  • in create new task form inputs has font that is not really clear; it should be thicker or maybe darker
  • rounded corners in general could be more rounded, according to the mockups :3

@koszar91
Copy link
Contributor

Little bug: after submitting newly-done task we're not redirected to the home page.

@john-sonz
Copy link
Collaborator Author

in create new task form inputs has font that is not really clear; it should be thicker or maybe darker

What do you mean it's not clear? It's literally black, can't get darker than that xD

image

rounded corners, in general, could be more rounded, according to the mockups :3

I wouldn't go too far with rounding, too much of it starts looking a bit ridiculous, and we should have different levels of rounding for different types of elements.

@john-sonz john-sonz requested a review from koszar91 April 26, 2022 09:18
@koszar91
Copy link
Contributor

The thing is it's the operating system difference, i guess.
image
I think you should make it a bit more consistent, if possible.
Another examples:
image
Up to me it is not our font.

Copy link
Contributor

@koszar91 koszar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styles should be more consistent between operating systems.

@john-sonz
Copy link
Collaborator Author

@koszar91 I updated the font family to be the same as in Figma, and the same across all OS.

@john-sonz john-sonz requested a review from koszar91 April 26, 2022 14:45
Copy link
Contributor

@koszar91 koszar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! There is a big difference with this font change, now it actually looks beautiful!

@john-sonz john-sonz merged commit 1ec9394 into develop Apr 27, 2022
@john-sonz john-sonz deleted the feature/ITG-95 branch April 27, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants