-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ITG-97] Add, remove, create tags in task edit. #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only styling issues
label: string; | ||
} | ||
|
||
const useTags = ({ tags, taskId }: Props) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
|
||
const { data, isLoading, error } = useQuery(getTags.cacheKey, getTags.run); | ||
|
||
const allTags = data?.data as ITag[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const allTags = data?.data as ITag[]; | |
const allTags = (data?.data || []) as ITag[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🔥🔥🔥🔥🔥
I left one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what's more beautiful: code or UI
Congratz!
I have problem with
Creatable
component fromreact-select
in file TagsEdit.tsx.If I use commented code, functionality will work, but I have a lot error by problem with types. (I write this basis on examples in internet).
If I change code to meet with types, edit card won't work.
Creatable component
Some example
Edit: Solved