Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ITG-105] feat: use enum task status #33

Merged
merged 5 commits into from
May 5, 2022
Merged

[ITG-105] feat: use enum task status #33

merged 5 commits into from
May 5, 2022

Conversation

tgargula
Copy link
Contributor

@tgargula tgargula commented May 2, 2022 •
edited

  • Remove is_done field
  • Add TaskStatus enum field
  • Adjust backend and frontend to changes
  • Interchangeable task completion makes the task INDIRECTLY_DONE
  • In Frontend it is treated as DONE so the behavior doesn't change. The rest will be done in ITG-106

Resources

@tgargula tgargula self-assigned this May 2, 2022
@tgargula tgargula requested a review from basiav May 2, 2022 19:41
koszar91
koszar91 requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@koszar91 koszar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, just some minor issues with Enums in Python 💪

bode/bode/models/task_actions.py Outdated Show resolved Hide resolved
bode/bode/models/task.py Outdated Show resolved Hide resolved
bode/bode/resources/tasks/schemas.py Outdated Show resolved Hide resolved
bode/bode/models/task.py Show resolved Hide resolved
john-sonz
john-sonz reviewed May 3, 2022
View reviewed changes
bode/bode/models/task.py Outdated Show resolved Hide resolved
bode/bode/models/task.py Outdated Show resolved Hide resolved
koszar91
koszar91 approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@koszar91 koszar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 💪

bode/bode/models/task_actions.py Outdated Show resolved Hide resolved
@tgargula @koszar91
chore: apply suggestions from code review
1e90657 
Co-authored-by: Tomek Koszarek <72392522+koszar91@users.noreply.github.com>
@tgargula tgargula merged commit 6dca464 into develop May 5, 2022
@tgargula tgargula deleted the feature/ITG-105 branch May 5, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koszar91 koszar91 koszar91 approved these changes

@gregori0o gregori0o gregori0o approved these changes

@basiav basiav Awaiting requested review from basiav

@john-sonz john-sonz Awaiting requested review from john-sonz

Assignees

@tgargula tgargula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tgargula @john-sonz @koszar91 @gregori0o