[ITG-103] List of relation types added to Task #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkulawska
changed the title
gregori0o
requested changes
May 10, 2022
john-sonz
approved these changes
May 11, 2022
… into features/ITG-103
parent 57aafeb author bkulawska <kulawska1507@gmail.com> 1652259157 +0200 committer bkulawska <kulawska1507@gmail.com> 1652260859 +0200 Made suggested changes. Fixed tags adding [NOJIRA] feat: add github bot (#40) * feat: add github bot * fix: github bot run * fix: another fix approach * feat: add quotes * feat: rename and fix indentation * feat: improve order and fix yml syntax * fix: excluded labels * fix: plzkillmeicannotwriteinyaml * fix: maybeorderchangewillhelp * fix: dontworryillsquashitanyway * fix: ifitisjustthisindentihateyaml * fix: avadakedavra * fix: maybedots? Fixed import. damniwillsquashitiswear
… into features/ITG-103
gregori0o
requested changes
May 11, 2022
gregori0o
reviewed
May 11, 2022
gregori0o
requested changes
May 11, 2022
There was a problem hiding this comment.
I found mistake with mapping name of relation types. The same is in file task_relations/api.py.
Co-authored-by: Grzegorz Legęza <glegeza@wp.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done some code refactoring with Janek while implementing the task; there was a problem with loop imports - we resolved that, not sure if it's optimal :)