Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITG-144] Eliminate cyclic imports between models #45

Merged
merged 4 commits into from
May 18, 2022

Conversation

john-sonz
Copy link
Collaborator

This PR refactors existing models by splitting the model definition and actions performed on the model to eliminate the cyclic imports between some model files.


Resources

ITG-114

Copy link
Contributor

@gregori0o gregori0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@john-sonz john-sonz merged commit 4a3f723 into develop May 18, 2022
@john-sonz john-sonz deleted the refactor/ITG-114 branch May 18, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants