Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITG-111] Przystosować backend do nowej mechaniki dodawania i edycji zadań #54

Merged
merged 6 commits into from
Jun 19, 2022

Conversation

bkulawska
Copy link
Contributor

@bkulawska bkulawska commented Jun 5, 2022

Only creation of tasks for now, let me know if the code is okay.
I tested manually from postman and it seems to be working fine.
This is how I expect the frontend to deliver the content (for creation):
image

EDIT:
Added edition as well.
Tested manually from postman again and it seems to be working fine.
This is how I expect the frontend to deliver the content (for edition):
image
You can see there's no "subtasksToDelete" list - it's because this can be done by passing the relationId to "relationsToDelete" list and that will suffice.

Copy link
Collaborator

@john-sonz john-sonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks alright so I think you can proceed to implementing the editing part

Copy link
Contributor

@koszar91 koszar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, good job, i hope task editing will not be harder than that

@bkulawska bkulawska marked this pull request as ready for review June 8, 2022 20:00
Copy link
Collaborator

@john-sonz john-sonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API shape here doesn't match the one in #55. @bkulawska, @koszar91 please decide on a common format and implement it.

bode/bode/models/task/actions.py Outdated Show resolved Hide resolved
bode/bode/models/task/actions.py Outdated Show resolved Hide resolved
bode/bode/models/task/actions.py Outdated Show resolved Hide resolved
bode/bode/resources/tasks/schemas.py Outdated Show resolved Hide resolved
@bkulawska bkulawska requested a review from john-sonz June 19, 2022 13:53
@john-sonz john-sonz merged commit d209a3e into develop Jun 19, 2022
@john-sonz john-sonz deleted the ITG-111 branch June 19, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants