[ITG-64,ITG-41,ITG-42] Routing and GET task implementation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgargula
commented
Apr 3, 2022
Comment on lines
+27
to
+32
| @blueprint.response(200, TaskSchema) | ||
| def get(self, task_id): | ||
| try: | ||
| return Task.query.get(task_id) or abort(404) | ||
| except DataError: | ||
| abort(404) |
There was a problem hiding this comment.
- if a correct UUID is passed -> returns a result if it exists. If not, responds with 404 (line 30)
- if an incorrect UUID is passed ->
DataErroris caught and also responds with 404 (line 32)
@bkulawska please, test if your implementation of DELETE works. I got some errors in an abort function when I tried to pass message kwarg as you did.
… github.com:it-goats/it-goats into feature/ITG-64-przekierowanie-do-szczegolow-zadania
john-sonz
reviewed
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
GET /tasks/task_idendpointreact-router-domLinks