⚡ mail_private New: internal users are flagged automatically #183

Ommo73 · 2019-03-21T11:19:02Z

Internal users are flagged automatically. Added button "Uncheck all"

yelizariev

You don't need to use 8️⃣ here. See https://gitlab.com/itpp/handbook/blob/master/documenting-updates.md#version-tags

yelizariev · 2019-03-21T20:49:04Z

mail_private/doc/changelog.rst

+`1.0.1`
+-------
+
+- Internal users are flagged automatically. Added button "Uncheck all".


For new feature you need to change version differently. Check documentation about it https://odoo-development.readthedocs.io/en/latest/dev/docs/__manifest__.py.html#version

One line per update. Use Version tags. See at the bottom of this doc: https://gitlab.com/itpp/handbook/blob/master/documenting-updates.md#changelog-tags

yelizariev · 2019-03-21T20:49:23Z

mail_private/doc/changelog.rst

@@ -1,6 +1,11 @@
 Updates
 =======


It's obsolete format. Please remove

mail_private/tests/test_js.py

mail_private/static/src/js/mail_private.js

hound · 2019-03-27T10:54:00Z

mail_private/static/src/js/mail_private.js

 openerp.mail_private = function(instance){

    var mail = instance.mail;

    instance.mail.ThreadComposeMessage.include({
        init: function (parent, datasets, options) {
            this._super.apply(this, arguments);
+            self = this;


Implicit global variable, assign as global property instead no-implicit-globals
Read-only global 'self' should not be modified no-native-reassign

KolushovAlexandr

1 Non-internal users are selected too
2 this Lint:
mail_private/models.py:7: [W0402(deprecated-module), ] Uses of a deprecated module 'openerp.osv'

KolushovAlexandr · 2019-04-11T08:28:33Z

mail_private/static/src/css/mail_private.css

+}
+.oe_mail .oe_msg_composer .oe_msg_content .oe_recipients {
+    margin-left: 0px;
+}


No new line at end of file

hound · 2019-04-17T10:17:22Z

mail_private/static/src/js/mail_private.js

            this.private = false;
+<<<<<<< HEAD
+=======


Expected an identifier and instead saw '==='.
Misleading line break before '==='; readers may interpret this as an expression boundary.
Unrecoverable syntax error. (6% scanned).

hound · 2019-04-17T10:17:23Z

mail_private/static/src/js/mail_private.js

            this.private = false;
+<<<<<<< HEAD


Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw '<<'.
Expected an operator and instead saw '<'.
Expected an operator and instead saw '<<'.
Missing semicolon.

hound · 2019-04-17T10:17:23Z

mail_private/static/src/js/mail_private.js

            this.private = false;
+<<<<<<< HEAD


Parsing error: Unexpected token <<

hound · 2019-04-17T10:17:23Z

mail_private/models.py

+    private = fields.boolean('Send Internal Message')
+
+    def get_internal_users_ids(self, cr, uid, context=None ):
+        return self.pool['res.users'].search(cr, uid, [('share','=',False)], context=context)


missing whitespace after ','

hound · 2019-04-17T10:17:23Z

mail_private/models.py

-    }
+    private = fields.boolean('Send Internal Message')
+
+    def get_internal_users_ids(self, cr, uid, context=None ):


whitespace before ')'

hound · 2019-04-17T10:17:23Z

mail_private/models.py


 from openerp.osv import osv, fields
-
+import wdb


'wdb' imported but unused

hound · 2019-04-17T10:20:31Z

mail_private/static/src/js/mail_private.js

+            this.users_ids = ResUser.call('get_internal_users_ids', [[]]).then( function (users_ids) {
+                return users_ids;
+            });
+            return this.users_ids


Missing semicolon.

hound · 2019-04-17T10:20:31Z

mail_private/static/src/js/mail_private.js

+                $(this).prop('checked', false);
+            });
+            _.each(self.recipients, function(res) {
+                res["checked"] = false;


['checked'] is better written in dot notation.

hound · 2019-04-17T10:20:31Z

mail_private/static/src/js/mail_private.js

+            this.users_ids = ResUser.call('get_internal_users_ids', [[]]).then( function (users_ids) {
+                return users_ids;
+            });
+            return this.users_ids


Missing semicolon semi

hound · 2019-04-17T10:20:32Z

mail_private/static/src/js/mail_private.js

+                        self.show_composer = !self.show_composer || self.stay_open;
+                        self.reinit();
+                    }
+                    if (!self.stay_open && self.show_composer && (!event || event.type != 'blur')) {


Expected '!==' and instead saw '!=' eqeqeq

hound · 2019-04-17T10:20:32Z

mail_private/static/src/js/mail_private.js

+
+                // when call for suggested partners finished: re-render the widget
+                $.when(suggested_partners).pipe(function (additional_recipients) {
+                    if ((!self.stay_open || (event && event.type == 'click')) && (!self.show_composer || !self.$('textarea:not(.oe_compact)').val().match(/\S+/) && !self.attachment_ids.length)) {


Expected '===' and instead saw '==' eqeqeq
Unexpected mix of '||' and '&&' no-mixed-operators

hound · 2019-04-17T10:20:32Z

mail_private/static/src/js/mail_private.js

+                                var parsed_email = mail.ChatterUtils.parse_email(recipient[1]);
+                                if (_.indexOf(email_addresses, parsed_email[1]) == -1) {
+                                    self.recipients.push({
+                                        'checked': (self.internal_users_ids.indexOf( recipient[3][0] ) != -1),


Expected '!==' and instead saw '!=' eqeqeq

hound · 2019-04-17T10:20:32Z

mail_private/static/src/js/mail_private.js

+                            var thread_recipients = additional_recipients[self.context.default_res_id];
+                            _.each(thread_recipients, function (recipient) {
+                                var parsed_email = mail.ChatterUtils.parse_email(recipient[1]);
+                                if (_.indexOf(email_addresses, parsed_email[1]) == -1) {


Expected '===' and instead saw '==' eqeqeq

mail_private/static/src/js/mail_private.js

KolushovAlexandr

https://github.com/it-projects-llc/mail-addons/pull/183/files#r269502551
https://github.com/it-projects-llc/mail-addons/pull/183/files#r276173622

KolushovAlexandr · 2019-05-08T12:28:47Z

mail_private/static/src/js/mail_private.js

    instance.mail.Thread.include({
        get_recipients_for_internal_message: function(ids, context){
            var self = this;
            self.result = {};
+            self.res_users = {};


KolushovAlexandr · 2019-05-08T13:00:15Z

mail_private/static/src/js/mail_private.js

+                                var parsed_email = mail.ChatterUtils.parse_email(recipient[1]);
+                                if (_.indexOf(email_addresses, parsed_email[1]) === -1) {
+                                    self.recipients.push({
+                                        'checked': (self.internal_users_ids.indexOf( recipient[3][0] ) !== -1),


you check only the first id from ids, so the rest users might be internal.

KolushovAlexandr · 2019-05-08T13:09:33Z

mail_private/static/src/js/mail_private.js

+        },
+        get_internal_users_ids: function () {
+            var ResUser = new instance.web.Model('mail.compose.message');
+            this.users_ids = ResUser.call('get_internal_users_ids', [[]]).then( function (users_ids) {


I think it would be better to keep this deferred variable as local for function than assign for a more global object. Is there any use of that?

mail_private/static/src/js/mail_private.js

…utton "Uncheck all"

yelizariev requested changes Mar 21, 2019

View reviewed changes

Ommo73 force-pushed the 8.0-mail_private_check_internal_users branch from 2d8775a to e8e543d Compare March 22, 2019 10:32

hound bot reviewed Mar 22, 2019

View reviewed changes

mail_private/tests/test_js.py Outdated Show resolved Hide resolved

mail_private/tests/test_js.py Outdated Show resolved Hide resolved

hound bot reviewed Mar 22, 2019

View reviewed changes

mail_private/tests/test_js.py Outdated Show resolved Hide resolved

mail_private/tests/test_js.py Outdated Show resolved Hide resolved

hound bot reviewed Mar 22, 2019

View reviewed changes

mail_private/tests/test_js.py Outdated Show resolved Hide resolved

mail_private/tests/test_js.py Outdated Show resolved Hide resolved

Ommo73 mentioned this pull request Mar 22, 2019

10.0 mail private add channels #182

Merged

hound bot reviewed Mar 27, 2019

View reviewed changes

Ommo73 force-pushed the 8.0-mail_private_check_internal_users branch from df060be to 0df6766 Compare March 28, 2019 12:04

Ommo73 changed the title ~~⚡8️⃣ mail_private New: internal users are flagged automatically~~ ⚡ mail_private New: internal users are flagged automatically Apr 4, 2019

Ommo73 force-pushed the 8.0-mail_private_check_internal_users branch 3 times, most recently from 11a6954 to a2f8f33 Compare April 10, 2019 14:01

KolushovAlexandr suggested changes Apr 11, 2019

View reviewed changes

hound bot reviewed Apr 17, 2019

View reviewed changes

Ommo73 force-pushed the 8.0-mail_private_check_internal_users branch from 74bd3b7 to 252cc82 Compare April 17, 2019 10:52

Ommo73 force-pushed the 8.0-mail_private_check_internal_users branch from bf7187e to 10ba230 Compare April 26, 2019 12:47

KolushovAlexandr suggested changes May 8, 2019

View reviewed changes

Ommo73 force-pushed the 8.0-mail_private_check_internal_users branch from 10ba230 to 9d2a8da Compare May 14, 2019 11:51

hound bot reviewed May 14, 2019

View reviewed changes

mail_private/static/src/js/mail_private.js Outdated Show resolved Hide resolved

mail_private/static/src/js/mail_private.js Outdated Show resolved Hide resolved

Ommo73 force-pushed the 8.0-mail_private_check_internal_users branch 2 times, most recently from 4e30200 to 5452873 Compare May 14, 2019 12:49

⚡ mail_private New: internal users are flagged automatically. Added b…

1046814

…utton "Uncheck all"

Ommo73 force-pushed the 8.0-mail_private_check_internal_users branch from 5452873 to 1046814 Compare May 15, 2019 09:49

KolushovAlexandr approved these changes May 15, 2019

View reviewed changes

Ramil-Mukhametzyanov approved these changes May 21, 2019

View reviewed changes

yelizariev approved these changes May 21, 2019

View reviewed changes

yelizariev merged commit bb296f0 into itpp-labs:8.0 May 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚡ mail_private New: internal users are flagged automatically #183

⚡ mail_private New: internal users are flagged automatically #183

Ommo73 commented Mar 21, 2019

yelizariev left a comment

yelizariev Mar 21, 2019

yelizariev Mar 21, 2019

yelizariev Mar 21, 2019

hound bot Mar 27, 2019

KolushovAlexandr left a comment •

edited

Loading

KolushovAlexandr Apr 11, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

hound bot Apr 17, 2019

KolushovAlexandr left a comment

KolushovAlexandr May 8, 2019

KolushovAlexandr May 8, 2019

KolushovAlexandr May 8, 2019

⚡ mail_private New: internal users are flagged automatically #183

⚡ mail_private New: internal users are flagged automatically #183

Conversation

Ommo73 commented Mar 21, 2019

yelizariev left a comment

Choose a reason for hiding this comment

yelizariev Mar 21, 2019

Choose a reason for hiding this comment

yelizariev Mar 21, 2019

Choose a reason for hiding this comment

yelizariev Mar 21, 2019

Choose a reason for hiding this comment

hound bot Mar 27, 2019

Choose a reason for hiding this comment

KolushovAlexandr left a comment • edited Loading

Choose a reason for hiding this comment

KolushovAlexandr Apr 11, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

hound bot Apr 17, 2019

Choose a reason for hiding this comment

KolushovAlexandr left a comment

Choose a reason for hiding this comment

KolushovAlexandr May 8, 2019

Choose a reason for hiding this comment

KolushovAlexandr May 8, 2019

Choose a reason for hiding this comment

KolushovAlexandr May 8, 2019

Choose a reason for hiding this comment

KolushovAlexandr left a comment •

edited

Loading