Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed endpoint "habit/custom" in order to have opportunity to add habit with image #5728

Merged
merged 4 commits into from
May 2, 2023

Conversation

LiliaMokhnatska
Copy link
Contributor

@LiliaMokhnatska LiliaMokhnatska commented May 1, 2023

Summary Of Issue :

A custom habit is saved only wiht url of image. Need to have opportunity to add habit with image with multipart data.

Issue Link

#5732

Summary Of Changes :

  1. changed post "habit/custom" in HabitController
  2. changed test in HabitControllerTest
  3. changed method addCustomHabit in HabitService
  4. changed method addCustomHabit in HabitServiceImpl and added new constant for default image
  5. changed ModelUtils
  6. changed and added new tests to HabitServiceImplTest

CHECK LIST

  • Code is up-to-date with the dev branch.
  • You've successfully built and run the tests locally.
  • There are new or updated unit tests validating the change.
  • JIRA/ Github Issue number & title in PR title (ISSUE-: Ticket title)
  • This template filled (above this section).
  • Sonar's report does not contain bugs, vulnerabilities, security issues, code smells ar duplication
  • NEED_REVIEW and READY_FOR_REVIEW labels are added.
  • All files reviewed before sending to reviewers

@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@LiliaMokhnatska LiliaMokhnatska merged commit 3f0dc80 into dev May 2, 2023
3 checks passed
@LiliaMokhnatska LiliaMokhnatska deleted the custom_habit_image branch May 2, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants