Release 1.2.0 #2383
Open
Release 1.2.0 #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed redirection after cancelling any dirty form edit by second time in UserConfigEditComponent, marked other components with forms and CreateGuard with TODO for fix * CreateFormComponent: add two abstract methods onSubmit() and onCancel() For all inheritors for this component fixed `this.location.back()` ignoring CreateGuard issue and changed it for `this.router.navigate()`. Where it possible - using relative path to parent route, otherwise - manually specified route * Removed TODO about moving `addNavPath()` method in `CreateDirectionComponent`to abstract component because it is done already
* Fixed a case where data was expected that was not requested because it was not needed for this role. Because of this endless waiting the user was not displayed information about the deputy.
* Refactored Admin store actions and state, add territorialCommunityAdmin model and service * Add parentId for codeficator actions and service search * Fixed Admin factory code when creating territorial community admin without id * Implemented territorial community admin create/update, selecting territorial community in codeficator autocomplete, add button disabling when form not valid in create-admin form * Fixed wrong path of importing TerritorialCommunityAdmin model * Fixed clear territorial community form control (because of community depends on region) when region changes, even if territorial community control doesn't exist * Migrated inputs/autocompletes of regions/territorial communities to dropdowns * Fixed edit form title of admins & fetching regions in form asynchronous, fixed fetching territorial communities while editing admin * Removed blank line between interfaces in territorialCommunityAdmin model * Removed `areaAdmin` string in territorial community service, moved it as enum * Made `parentId` in Codeficator search number instead of string * Made unable choosing territorial community if chosen region is city with special status
* Refactored Admin store actions and state, add territorialCommunityAdmin model and service * Add parentId for codeficator actions and service search * Fixed Admin factory code when creating territorial community admin without id * Implemented territorial community admin create/update, selecting territorial community in codeficator autocomplete, add button disabling when form not valid in create-admin form * Fixed wrong path of importing TerritorialCommunityAdmin model * Fixed clear territorial community form control (because of community depends on region) when region changes, even if territorial community control doesn't exist * Migrated inputs/autocompletes of regions/territorial communities to dropdowns * Fixed edit form title of admins & fetching regions in form asynchronous, fixed fetching territorial communities while editing admin * Removed blank line between interfaces in territorialCommunityAdmin model * Removed `areaAdmin` string in territorial community service, moved it as enum * Made `parentId` in Codeficator search number instead of string * Made unable choosing territorial community if chosen region is city with special status * Improved method `fillTerritorialCommunity` and moved two subscriptions of store dispatching to `switchMap` RxJS operator
* Fixed a bug with incorrect information about workshop * Added access modificators
…s no seats for (#2155) * Add modal for workshop seats lack case that offers to change seats number; also provided min seats number in workshop editing if seats are already taken or there are recruitment open (taken seats + 1). * Formatted modal template and workshop status update dispatching
…rkshop list page (#2161)
* Made filtering, adaptivity, fixed bag with hovering of option in translate dropdown, made button for clearing all filters to providers list, filled 3 dropdowns of institutions, regions, areas. Made translate for this dropdowns. * Made separating by roles of filters and visibility of dropdowns, refactored code, remade reset of filters, separated code to methods * Fixed imports * Made the requested changes * Remade formatting of constructor * Remade getters to constants for condition of resetting parameters * Added import for WorkshopSeatsLackModalComponent * Refactored onResetFilters
* Fixed an issue with validation text indentation of email input. * Fixed issue with indentation and alignment of validation text of working hours inputs * Improvmented text of tooltip
* Add email regex and email validator, moved all default Angular validators to created validator. TODO regex * Implemented email regex. Also moved: - HOUSE_REGEX [0-9] to \d - NAME_REGEX removed duplicate ' symbol - TEXT_REGEX and NAME_REGEX removed duplicate ' ' (space symbol) because of using \s (space metacharacter) * Changed double quotes in import to single quotes due to linter * Refactored validation hint, renamed typo in minCharacters and maxCharacters * Wrote custom email validator with `email` field in ValidationErrors, so validation hint will be displayed as earlier * Fixed 'characters' validation typo in tests * Add validation hint for email in create admin * Refactored templates
…tered data (#2167) * added the validators to the section title field * fixed the increasing of the error field --------- Co-authored-by: SergeyGSA <goreslavskiy.sergey@gmail.com>
…ial symbols, but require to end string only with letters (#2175)
* Set max number of "TO" age input, refactored quotes and imports * Refactored quotes
…umber of symbols and max number (#2174) * Set max length on input in chat and made label that showing current number of symbols and max number * Refactored quotes
…2173) * Refactored confirmation modal window template, removed redundant question mark in translations where it isn't needed because of providing title TODO: Deal with quotes in modal where it shouldn't be (for example person name) * Add separate enum for modal text that require quotes
* Removed duplicate key in translation * Add EDRPOU/IPN validator, refactored create-info form and validator hint
As we're not differentiating between read or write operations in OIDC, change the scope to more generic.
* globally added custom mat-tooltip options * provided option locally * changed naming
…creens. (#2539) * Fixed dropdown. Now text fits in perfectly. Also information icon is now positioned propperly. Also fixed some statuses that were shifted one character to the right under workshop * Expanded width of form field infix for english version look better * added some styles * Modified some styles. Centered the title inside the dropdown. * Made padding in label smaller so the text looks better and is in the center of the dropdown
…plications fixed. (#2547) * Interaction buttons display for mobile phone view fixed. * Changed padding for only small screens
…are stretched nicely. (#2542) * Fixed dropdown. Now text fits in perfectly. Also information icon is now positioned propperly. Also fixed some statuses that were shifted one character to the right under workshop * Expanded width of form field infix for english version look better * added some styles * Modified some styles. Centered the title inside the dropdown. * Made padding in label smaller so the text looks better and is in the center of the dropdown * Made application card look better by making width auto for card-block
#2540) * Changed field stylesheets so that they are on the same level. Changed datepicker styles so the content is in the middle of the container * added additional class to specify which form field should have padding set to 0 --------- Co-authored-by: AkunaPatlata <94176568+AkunaPatlata@users.noreply.github.com>
* Dvorak / 2546 Interaction buttons display for mobile phone view fixed. * Changed padding for only small screens * Fixed card styles for provider * Deleted padding for kebab menu
…2557) * Add type-restriction for filter options, customized log value, fixed naming * Fixed tests * Fixed reset button * Add tests
…e date of achievement of the workshop (#2553) * Changed min limit of datepicker to 100 years before current date. Sonarlint fixes * Set max limit of datepicker to 100 years after current data * Removed redefinition of 'destroy$' field, as it was done in other classes that are extended from CreateFormComponent class, where 'destroy$' property is already defined
…m 'Відправити' to 'Надіслати' (#2560)
* Created CreateParentComponent, added guard, translation and routing * Fixed guard, added new translate for message bar * Added tests for CreateParentComponent and CreateParentGuard. Added logic for button submit * Fixed lint * Fixed tests * Fixed lint * Fixed lint * Added new test for service * Fixed lint * Fixed test for personal cabinet guard * Added exclusions for coverage * Added payload for Fail and Success create provider and parent * Fixed message bar for provider and parent. Also added condition for dialog menu from workshop details * Fixed comments * Fixed comment * Fixed lint
* Not final result * Dvorak / 2568 The indication of currency positioning fixed * Minor fix * Code refactored
* Dvorak / 2565 Message is being send by pressing Enter * Tests added * Modified tests * jest.spyOn added
…d to the workshop without competitive selection (#2575) * Changed text in enroll button when the workshop without competitive selection from 'Прийняти' to 'Зарахувати' * removed unnecessary condition for reason that "Enroll" button should be displayed even the application is already rejected
… type to default when 'Add child' button is disabled (#2577)
* Dvorak / 2546 Interaction buttons display for mobile phone view fixed. * Changed padding for only small screens * Fixed card styles for provider * Deleted padding for kebab menu * Fixed some styles for personal cabinets applications * Minor styles fix * Accepted for selection description fix
…n' should contain the information about selection specified on the workshop page (#2584) * Created 'getWorkshopCompetitiveSelectionDescriptionById' method in UserWorkshopService Changed info-status template to show competitive selection description if user has applicationStatus AcceptedForSelection * fix tests * lint fix * lint fix * replaced 'toString' method with enum in 'if' statement * fixed formatting of inside *ngIf
…ng fix (#2594) * First version * Dvorak / 2549 Burger menu, name of the menu tab and indicator positioning fix * Minor update * Changed camelCase to kebab-case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.