Smyk / 2583 The button '+Додати ще дитину' should be disabled if the parent already has 20 children #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ildren. Added information button with pop-up message when the parent already has 20 children.
humanmantis
requested changes
Jun 23, 2024
There was a problem hiding this comment.
I think we can make a property that will show that the child limit is reached and reuse it inside the template instead of checking the number of children 5 times
humanmantis
requested changes
Jul 2, 2024
| @@ -99,6 +100,7 @@ export class CreateApplicationComponent implements OnInit, OnDestroy { | |||
| this.children$.pipe(filter(Boolean), takeUntil(this.destroy$)).subscribe((children: SearchResponse<Child[]>) => { | |||
| this.parentCard = children.entities.find((child: Child) => child.isParent); | |||
| this.children = children.entities.filter((child: Child) => !child.isParent); | |||
| this.has20Children = this.children.length >= 20; | |||
There was a problem hiding this comment.
A magic number in the property name is not the best option.
It is better to name it something like isChildLimitReached and create a constant MAX_CHILD or similar
…dBeDisabledIfTheParentAlreadyHas20Children
…omparing to 20 with CHILDREN_AMOUNT_MAX constant
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2583
Disabled 'Add another child' button when the parent already has 20 children.
Added information button with pop-up message when the parent already has 20 children.