#38 Implement Feedback Given #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IanOdhiambo9 Awaiting feedback and review |
|
No screenshots provided for your work, mobile and web. |
IanOdhiambo9
requested changes
Feb 13, 2023
Comment on lines
1
to
7
| <div class="center"> | ||
| <ul> | ||
| <li *ngFor="let image of imageUrl"> | ||
| <img src="{{image.image}}" height="25" width="75"> | ||
| </li> | ||
| </ul> | ||
| </div> |
There was a problem hiding this comment.
spaces/indent should be 2
Comment on lines
1
to
19
| .center{ | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| ul{ | ||
| width: 100vw; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
| li{ | ||
| list-style-type: none; | ||
| height: 20px; | ||
| width: 30px; | ||
| padding: 30px; | ||
| } | ||
|
|
There was a problem hiding this comment.
Not styles for mobile view, should be a vertical list on mobile with org logos in pairs of 2 in each row
There was a problem hiding this comment.
@IanOdhiambo9 I've Implemented styles for the mobile view .
Comment on lines
9
to
38
| imageUrl = [ | ||
| { | ||
| id: 1, | ||
| "image": "https://rwanda.vvob.org/sites/rwanda/files/styles/780pxx330px/public/images/mainimagebig/ok.jpg?itok=zMR2_g-z" | ||
| }, | ||
| { | ||
| id: 2, | ||
| "image": "https://images.squarespace-cdn.com/content/v1/5c9b88e00cf57d033337013f/1560884247023-4T57CS4T1C6VX94JK5JV/farmbetter_for_website.png?format=1500w" | ||
| }, | ||
| { | ||
| id: 3, | ||
| "image": "https://www.greenclimate.fund/sites/default/files/organisation/logo-enabel.png" | ||
| }, | ||
| { | ||
| id: 4, | ||
| "image": "https://savics.org/wp-content/uploads/2020/10/SavicsREF_Horizontal_RGB.jpg" | ||
| }, | ||
| { | ||
| id: 5, | ||
| "image": "https://www.bigmaninthewoods.co.uk/wp-content/uploads/2018/05/1341315_scouts_logo_horizontal_purple.png" | ||
| }, | ||
| { | ||
| id: 6, | ||
| "image": "https://wwfke.awsassets.panda.org/img/wwf_logo_750_x_600_490968.jpg" | ||
| }, | ||
| { | ||
| id: 7, | ||
| "image": "https://wwfke.awsassets.panda.org/img/wwf_logo_750_x_600_490968.jpg" | ||
| } | ||
| ]; |
There was a problem hiding this comment.
No need for Id's just do a list of strings
|
@IanOdhiambo9 Implemented feedback given, awaiting review |
IanOdhiambo9
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a section on the site that lists Elewa group partners Horizontally.
To achieve this, we needed to:
Fixes #38
##Screenshots
Desktop
Mobile
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The Issue has been tasted by using various web browser
Checklist: