Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controllo automatico dei link rotti #24
base: master
Are you sure you want to change the base?
Controllo automatico dei link rotti #24
Changes from 122 commits
5aeff5b
0a350a1
8268e14
f340d02
26b64e2
01a53a8
f945608
5fc3dfe
f76ca30
f4abbe3
d783e9a
7bac23c
bac2647
ebed09b
5c36ff2
6a34b0a
5442276
9733074
67be6cf
23e8dd4
1f127e8
e4b2cff
41e238e
e7012e1
dfef35d
d8f82b3
03e6535
282d975
64edb4a
ee5120c
d6ed1bb
75eb107
fdc75ac
4e05303
9474867
98ef336
1eb9dd2
7791d2f
707db2b
0e434c4
5220df5
30bea08
53a13e3
2029d35
314ea44
54ceb20
1abe6f6
731d244
d49d3c7
e245a0e
ec1b95f
6fcc9c4
14ea678
62e1e9f
14cc654
07d9d02
0de091f
205f9cf
d4200d9
e4aa2d0
5401fd1
1115d86
7022bb9
cc386ae
b1cdcdd
a7999a4
fb04dd5
5d28a8b
84d1850
b4e3d22
2d86873
a3e07ef
a606f46
ab940aa
6614e53
69a3f8a
bead17c
7f7e333
5d61bd2
7d93fbc
e342857
91b4ffa
58e85e1
9a22df7
6baf3ba
98ef475
c4604db
822618a
c385958
de566d2
82b8079
1442fbe
4702881
4bbabb7
826c4d4
867134f
209f7c3
225092a
243077d
82a1fdc
12ce878
e2b32b1
0a05ee4
df86408
12a3f1c
230ca88
272b26f
5bcae5a
04265d5
52aeed9
06ea065
1fe7743
2252d54
79de76a
4438644
5d92832
879d75a
b1e9511
735225e
f16eed3
bb953db
3c3055e
cc23f7f
dcdb863
38d4a6a
fdc02bc
8729562
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use just
sed
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use a bash array here (see below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this guaranteed by the regexps populating
$LINKS
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want
-k
here?Also we should probably keep the output, so we can check what's the specific problem in the action logs, if we want more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bash array will make this superflous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do this because we need a single file (
.github/workflows/ISSUE_TEMPLATE.md
) and doing so we get the whole history and the rest of the repo. Not a big deal, but maybe we can optimize that, also considering it interferes with theif: failure()
logic (see below).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this action create a new issue everytime? Because if thats the case, we want to create a new issue if there's no issue opened yet, but update the issue if there is already one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will run when the link checker job is successful, in case
actions/checkout
fails.