Moved the PKCS#11 SDK to a common directory #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paths of CSP and EsempioPKCS11 to it: much better than having two identical copies of the SDK in two different projects. As a bonus, fixes the build of EsempioPKCS11
hackbunny
force-pushed
the
pkcs11-sdk
branch
from
477341f
to
3d88f4b
Compare
ugochirico
pushed a commit
that referenced
this pull request
Mar 25, 2019
Moved the PKCS#11 SDK to a common directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EsempioPKCS11 wasn't building for me, as it couldn't find the
win32.hinclude. I noticed that the EsempioPKCS11 and CSP projects both had their own (identical) copy of the PKCS#11 SDK, except the former's was incomplete, missing thewin32.hfile. To fix both the duplication issue and the build issue, I moved the SDK to a common directory (PKCS11in the top level directory), and pointed the include paths of both projects to it