feat: create Software even if publiccode.yml is invalid #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only created a new Software entity only when the publiccode.yml is valid, so in case of a new repo with an invalid publiccode.yml nothing was added. This means the new software didn't exist from the API's point of view, and because of that publiccode-issueopener can't notify the maintainers about the errors, even if new repos are arguably the ones where error reporting and a little hand holding are more valuable. So add the software even if publiccode.yml is invalid, setting active to false. We will re-activate software whenever publiccode.yml is valid *only* if it was previously added automatically for the first time as inactive.
bfabio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only created a new Software entity only when the
publiccode.yml is valid, so in case of a new repo with an invalid
publiccode.yml nothing was added.
This means the new software didn't exist from the API's point of view,
and because of that publiccode-issueopener can't notify the maintainers about
the errors, even if new repos are arguably the ones where error reporting and
a little hand holding are more valuable.
So add the software even if publiccode.yml is invalid, setting active to
false.
We will re-activate software whenever publiccode.yml is valid only
if it was previously added automatically for the first time as inactive.
Fix #325.