Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Language #234

Open
giosce opened this issue Jan 16, 2022 · 1 comment
Open

Add Language #234

giosce opened this issue Jan 16, 2022 · 1 comment

Comments

@giosce
Copy link

giosce commented Jan 16, 2022

I'm wondering on the purpose and behavior of "Add Language".
I set up my fork to have default language "us" (not a great user interface to use 2 letter codes...), try to generate e got the error of the "Sample USA" field mandatory. I add the "it" language and nothing changes in the Editor (I don't see the SPID and other Italian fields) and validation (it still complains about "Sample USA".

What should be the behavior? Use both us and it fields, validate all us and it fields?
@bfabio
Copy link
Member

bfabio commented Jan 18, 2022

Hello @giosce, "Add language" is supposed to add a description in that language. It should be a language, not a country and it's not related to country sections.

I agree it's confusing and there is a WIP branch to address this issue as well (among others) at https://github.com/sebbalex/publiccode-editor/tree/refactor

bfabio added a commit to bfabio/publiccode-editor that referenced this issue Jan 15, 2024
@bfabio
feat(l10n): refactor the localization code
c90ba7e 
* App localization is now based on the detected language from the
  browser at runtime
* Spell the whole language name in the UI
* Change the UI for multiple languages in the publiccode.yml file,
  removing the tabs
* Use a library for the list of languages, so we don't have to maintain
  our own

Obsoletes italia#247
Related italia#234
Fix italia#123
bfabio added a commit to bfabio/publiccode-editor that referenced this issue Jan 15, 2024
@bfabio
feat(l10n): refactor the localization code
95959e4 
* App localization is now based on the detected language from the
  browser at runtime
* Spell the whole language name in the UI
* Change the UI for multiple languages in the publiccode.yml file,
  removing the tabs
* Use a library for the list of languages, so we don't have to maintain
  our own

Obsoletes italia#247
Related italia#234
Fixes italia#123, Fixes italia#26
@bfabio bfabio mentioned this issue Jan 15, 2024
Merged
bfabio added a commit that referenced this issue Jan 16, 2024
@bfabio
feat(l10n): refactor the localization code (#296)
17404a9 
* App localization is now based on the detected language from the
  browser at runtime
* Spell the whole language name in the UI
* Change the UI for multiple languages in the publiccode.yml file,
  removing the tabs
* Use a library for the list of languages, so we don't have to maintain
  our own

Obsoletes #247
Related #234
Fixes #123, Fixes #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bfabio @giosce