Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When some keys are in error, mandatory key are not enforced #19

Closed
sebbalex opened this issue Oct 14, 2019 · 1 comment · Fixed by #81
Closed

When some keys are in error, mandatory key are not enforced #19

sebbalex opened this issue Oct 14, 2019 · 1 comment · Fixed by #81
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Refactoring
Milestone
2.0.0

Comments

@sebbalex
Copy link
Member

When validating a Publiccode which has some error in compilation and some mandatory keys missing, it only enforce for malformed keys and not for required. Solving compilation errors it warns you about the required key missing.
I expect the full list on what's going wrong every time.
@sebbalex sebbalex added the bug Something isn't working label Oct 14, 2019
@sebbalex sebbalex added this to the 1.0.2 milestone Feb 4, 2020
@sebbalex sebbalex modified the milestones: 1.0.2, 1.1.0 Jun 16, 2020
@sebbalex sebbalex added the help wanted Extra attention is needed label Jun 22, 2020
@libremente libremente added this to To do in Hacktoberfest 2020 Sep 30, 2020
@bfabio
Copy link
Member

bfabio commented Oct 29, 2020

Depends on #74.

@bfabio bfabio removed this from To do in Hacktoberfest 2020 Oct 29, 2020
@bfabio bfabio modified the milestones: 1.2.0, 2.0.0 Oct 29, 2020
@bfabio bfabio added this to To do in Refactoring Dec 28, 2020
@bfabio bfabio moved this from To do to Done in Refactoring Feb 1, 2021
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Feb 14, 2021
@bfabio
feat!: big refactoring of internals
3f826c6 
* Refactored the way the library does validation: now we use
  github.com/go-playground/validator/v10 instead of custom ones.
* Now Parse() always return ValidationErrors containing one or more
  ValidationError if any validation error is present.
* The parser tries not to stop the validation early and give as many
  errors as possible immediately.
* The strict mode was removed
* The default output is now errorformat friendly
  (https://vim-jp.org/vimdoc-en/quickfix.html#error-file-format)
* pcvalidate learned the -json switch to ouput the report as JSON
* Specify the errored keys as a subset of JSONPath
  (fe. documentation.eng.features[3])

Fix italia#76, Fix italia#19, Fix italia#74, Fix italia#60.
@bfabio bfabio mentioned this issue Feb 14, 2021
Merged
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Feb 16, 2021
@bfabio
feat!: big refactoring of internals
517159a 
* Refactored the way the library does validation: now we use
  github.com/go-playground/validator/v10 instead of custom ones.
* Now Parse() always return ValidationErrors containing one or more
  ValidationError if any validation error is present.
* The parser tries not to stop the validation early and give as many
  errors as possible immediately.
* The strict mode was removed
* The default output is now errorformat friendly
  (https://vim-jp.org/vimdoc-en/quickfix.html#error-file-format)
* pcvalidate learned the -json switch to ouput the report as JSON
* Specify the errored keys as a subset of JSONPath
  (fe. documentation.eng.features[3])

Fix italia#76, Fix italia#19, Fix italia#74, Fix italia#60.
@sebbalex sebbalex mentioned this issue Feb 24, 2021
Open
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Jun 16, 2021
@bfabio
feat!: big refactoring of internals
62f1852 
* Refactored the way the library does validation: now we use
  github.com/go-playground/validator/v10 instead of custom ones.
* Now Parse() always return ValidationErrors containing one or more
  ValidationError if any validation error is present.
* The parser tries not to stop the validation early and give as many
  errors as possible immediately.
* The strict mode was removed
* The default output is now errorformat friendly
  (https://vim-jp.org/vimdoc-en/quickfix.html#error-file-format)
* pcvalidate learned the -json switch to ouput the report as JSON
* Specify the errored keys as a subset of JSONPath
  (fe. documentation.eng.features[3])

Fix italia#76, Fix italia#19, Fix italia#74, Fix italia#60.
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Mar 11, 2022
@bfabio
feat!: big refactoring of internals
27701f6 
* Refactored the way the library does validation: now we use
  github.com/go-playground/validator/v10 instead of custom ones.
* Now Parse() always return ValidationErrors containing one or more
  ValidationError if any validation error is present.
* The parser tries not to stop the validation early and give as many
  errors as possible immediately.
* The strict mode was removed
* The default output is now errorformat friendly
  (https://vim-jp.org/vimdoc-en/quickfix.html#error-file-format)
* pcvalidate learned the -json switch to ouput the report as JSON
* Specify the errored keys as a subset of JSONPath
  (fe. documentation.eng.features[3])

Fix italia#76, Fix italia#19, Fix italia#74, Fix italia#60.
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Mar 11, 2022
@bfabio
feat!: big refactoring of internals
1bfb94c 
* Refactored the way the library does validation: now we use
  github.com/go-playground/validator/v10 instead of custom ones.
* Now Parse() always return ValidationErrors containing one or more
  ValidationError if any validation error is present.
* The parser tries not to stop the validation early and give as many
  errors as possible immediately.
* The strict mode was removed
* The default output is now errorformat friendly
  (https://vim-jp.org/vimdoc-en/quickfix.html#error-file-format)
* pcvalidate learned the -json switch to ouput the report as JSON
* Specify the errored keys as a subset of JSONPath
  (fe. documentation.eng.features[3])

Fix italia#76, Fix italia#19, Fix italia#74, Fix italia#60.
bfabio added a commit to bfabio/publiccode-parser-go that referenced this issue Feb 18, 2023
@bfabio
feat!: big refactoring of internals
91f457c 
* Refactored the way the library does validation: now we use
  github.com/go-playground/validator/v10 instead of custom ones.
* Now Parse() always return ValidationErrors containing one or more
  ValidationError if any validation error is present.
* The parser tries not to stop the validation early and give as many
  errors as possible immediately.
* The strict mode was removed
* The default output is now errorformat friendly
  (https://vim-jp.org/vimdoc-en/quickfix.html#error-file-format)
* pcvalidate learned the -json switch to ouput the report as JSON
* Specify the errored keys as a subset of JSONPath
  (fe. documentation.eng.features[3])

Fix italia#76, Fix italia#19, Fix italia#74, Fix italia#60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
No open projects
Refactoring
Done
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

feat!: big refactoring of internals bfabio/publiccode-parser-go
2 participants
@bfabio @sebbalex