Issue #6 | Add SqlServer support | Adarsh #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@italolelis I see an error in coverall |
m4ver1k
force-pushed
the
Add-SQLSERVER-Support
branch
from
180102a
to
db17886
Compare
|
Hey @m4ver1k, Thank you for contribution. Regarding the failing CI, I think it has something to do with the way GithubActions work in a forked PR. The env var is set in this repo, but if the PR comes from a fork, it doesn't have access to that variable. I'll see if I can only run that step in master or something like that. |
|
@m4ver1k All right, now I have split the workflow for master and pull requests. I also updated our linting version, and now the PR has a few linting errors. If you don't mind fixing them I would appreciate it. Thanks!! |
|
Sure will do that |
|
@italolelis I have fixed the linting issues. |
italolelis
approved these changes
Oct 28, 2019
|
@m4ver1k Thank you very much for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.