Make main thread detection a bit less fragile #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@itamarst Any chance we could take this as a quick fix for the issue soon? |
|
I was hoping to get #81 in soon; if that doesn't happen by this weekend I'll merge this and do another release and do #81 in the release after that. Sound good? Meanwhile, could you merge forward and:
Then I can just merge easily. Thanks! |
|
@itamarst ahh, didn't notice 3.3 under all the pypys, yeah I can take care of that. |
bpicolo
force-pushed
the
less_fragile_main_thread_detection
branch
from
3b4744a
to
0ea6fd8
Compare
itamarst
added a commit
that referenced
this pull request
May 2, 2015
Make main thread detection a bit less fragile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should make the main thread detection a bit less fragile? Seems to work fine uwsgi worker processes, whereas the other version didn't =|
https://hg.python.org/cpython/file/2.7/Lib/threading.py#l1085 special class in thread lib just for the main thread
Edit: Heh, #81 is not entirely unlike my issue probably. Might want some combination of both of those pulls
Aha. Fixes #78 for uWsgi. :D I see now others had the same issue