Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unlurk user bug; Add StreamEvent Handler #83

Merged
merged 9 commits into from
Mar 1, 2024
Merged

Fix Unlurk user bug; Add StreamEvent Handler #83

merged 9 commits into from
Mar 1, 2024

Conversation

itanex
Copy link
Owner

@itanex itanex commented Mar 1, 2024

  • Address Unlurk of users at end of stream
  • Create StreamEventHandler to facilitate fix
  • Add unit tests for StreamEventHandler

closes #82

@itanex itanex added bug Something isn't working enhancement New feature or request Testing Tasks related to testing the application labels Mar 1, 2024
@itanex itanex added this to the Production Release 1.3 milestone Mar 1, 2024
@itanex itanex self-assigned this Mar 1, 2024
itanex
itanex commented Mar 1, 2024
View reviewed changes
Copy link
Owner Author

@itanex itanex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. remove the "todo" comment from the test when finishing 100% coverage

@itanex itanex merged commit 096c41c into main Mar 1, 2024
2 checks passed
@itanex itanex deleted the bug/82-unlurk-cleanup branch March 1, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@itanex itanex

Labels
bug Something isn't working enhancement New feature or request Testing Tasks related to testing the application
Projects
None yet
Milestone
Production Release 1.3
Development

Successfully merging this pull request may close these issues.

Update Unlurk Cleanup to be end of stream
1 participant
@itanex